Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add obdaac s3-credential endpoint #516

Merged
merged 5 commits into from
Apr 12, 2024
Merged

add obdaac s3-credential endpoint #516

merged 5 commits into from
Apr 12, 2024

Conversation

itcarroll
Copy link
Collaborator

@itcarroll itcarroll commented Apr 11, 2024

OB.DAAC is joining the PARTY!


📚 Documentation preview 📚: https://earthaccess--516.org.readthedocs.build/en/516/

jhkennedy
jhkennedy previously approved these changes Apr 11, 2024
Copy link
Collaborator

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I confirmed the homepage change and that the s3-redentials endpoint README is there:
https://obdaac-tea.earthdatacloud.nasa.gov/s3credentialsREADME

@itcarroll
Copy link
Collaborator Author

Thanks! Waiting to unset draft to get a nod from our programmers.

@itcarroll
Copy link
Collaborator Author

@quixrick I'm adding the OB.DAAC s3credential endpoint to the earthaccess package. Pinging you for awareness and to confirm that the OB.DAAC uses the same provider ID for cloud hosted data that it uses for self-hosted data, correct?

@quixrick
Copy link

quixrick commented Apr 12, 2024

Our cloud provider is "OB_CLOUD". Otherwise, this looks okay to me. 👍
-Rick

@itcarroll itcarroll marked this pull request as ready for review April 12, 2024 15:26
@itcarroll
Copy link
Collaborator Author

@jhkennedy Your review (which, while appreciated, came earlier than desired) was abrogated when I unset draft. Ready for review now, please & thank you.

Copy link
Member

@betolink betolink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! just a note, S3 credentials are also picked up from the metadata if they are available. Eventually these hard-coded values should go away, in real life I don't know how good metadata will be from CMR cc @jhkennedy

@itcarroll
Copy link
Collaborator Author

@betolink These hard-coded values would still be needed for earthaccess.get_s3fs_session(daac="OBDAAC") though, right? Maybe that would go away too?

@betolink
Copy link
Member

Yeah they are still needed for that. Only when we use the results to download or open is when we don't really need them if the metadata is right. I guess they won't go away anytime soon.

@betolink betolink merged commit 8d65d03 into nsidc:main Apr 12, 2024
11 checks passed
@itcarroll itcarroll deleted the obdaac branch April 12, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants