-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add obdaac s3-credential endpoint #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I confirmed the homepage change and that the s3-redentials endpoint README is there:
https://obdaac-tea.earthdatacloud.nasa.gov/s3credentialsREADME
Thanks! Waiting to unset |
@quixrick I'm adding the OB.DAAC s3credential endpoint to the earthaccess package. Pinging you for awareness and to confirm that the OB.DAAC uses the same provider ID for cloud hosted data that it uses for self-hosted data, correct? |
Our cloud provider is "OB_CLOUD". Otherwise, this looks okay to me. 👍 |
@jhkennedy Your review (which, while appreciated, came earlier than desired) was abrogated when I unset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! just a note, S3 credentials are also picked up from the metadata if they are available. Eventually these hard-coded values should go away, in real life I don't know how good metadata will be from CMR cc @jhkennedy
@betolink These hard-coded values would still be needed for |
Yeah they are still needed for that. Only when we use the results to download or open is when we don't really need them if the metadata is right. I guess they won't go away anytime soon. |
OB.DAAC is joining the PARTY!
📚 Documentation preview 📚: https://earthaccess--516.org.readthedocs.build/en/516/