remove the unreferenced CLOUD_PROVIDERS list
#603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisher87
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Great catch! If we need a structure like this we can derive this from DAACS.
@betolink do you think we should delete it, or is there a need to keep the variable? In which case we can make it a list comprehension instead of a copy of the data.
|
I thought the code was using this list to flag cloud providers from the results but maybe that logic changed? I don't see where else this is being used so I think it would be OK to remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #564.
The bug does not appear to be that "OBDAAC" is missing from
earthaccess.daac.CLOUD_PROVIDERS. Rather, the issue seems to be that this list exists without having any function. TheCLOUD_PROVIDERSlist is not referenced in the project (according to VS Code and text search) and deleting it breaks no tests. This PR removes the cruft and does nothing else.Please close without merging if you're aware of any purpose for this variable.
As far as adding OBDAAC goes, I think it was added correctly in #516.
📚 Documentation preview 📚: https://earthaccess--603.org.readthedocs.build/en/603/