Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pool for Extensible payloads #1674

Merged
merged 3 commits into from
Jan 28, 2021
Merged

Add pool for Extensible payloads #1674

merged 3 commits into from
Jan 28, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Jan 19, 2021

We should store them in one place.
Close #1663 .

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #1674 (b83dc31) into master (32e8678) will decrease coverage by 0.02%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
- Coverage   82.66%   82.63%   -0.03%     
==========================================
  Files         239      240       +1     
  Lines       19546    19635      +89     
==========================================
+ Hits        16157    16226      +69     
- Misses       2392     2403      +11     
- Partials      997     1006       +9     
Impacted Files Coverage Δ
pkg/consensus/consensus.go 69.57% <ø> (-1.07%) ⬇️
pkg/core/blockchain.go 76.04% <64.10%> (-0.51%) ⬇️
pkg/network/server.go 72.10% <64.70%> (+0.56%) ⬆️
pkg/core/native/designate.go 74.48% <75.60%> (-2.94%) ⬇️
pkg/core/native/oracle.go 81.55% <100.00%> (ø)
pkg/network/extpool/pool.go 100.00% <100.00%> (ø)
pkg/rpc/client/wsclient.go 82.70% <0.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e8678...eba5bc7. Read the comment docs.

@fyrchik
Copy link
Contributor Author

fyrchik commented Jan 19, 2021

I don't like how whitelist is cached, but haven't come up with anything more simple. It would be good if whitelist was stored in the pool only, but it's calculation depends on native contract state.

Base automatically changed from extensible to master January 22, 2021 08:10
@roman-khimov
Copy link
Member

Rebase it please to only leave relevant commits.

pkg/core/native/designate.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/network/server.go Outdated Show resolved Hide resolved
pkg/network/server.go Outdated Show resolved Hide resolved
pkg/core/mempool/feer.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/core/native/designate.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/core/native/designate.go Outdated Show resolved Hide resolved
pkg/network/server.go Show resolved Hide resolved
@roman-khimov
Copy link
Member

Can we improve coverage to 80%+?

@roman-khimov
Copy link
Member

Tests fail here.

@roman-khimov
Copy link
Member

Conflicts.

@roman-khimov roman-khimov merged commit a6921ce into master Jan 28, 2021
@roman-khimov roman-khimov deleted the extensible_pool branch January 28, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extensible payloads and use them for consensus
3 participants