Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protoc-gen-go-grpc to generate protobuf files #176

Closed
alexvanin opened this issue Oct 20, 2020 · 0 comments · Fixed by #344
Closed

Use protoc-gen-go-grpc to generate protobuf files #176

alexvanin opened this issue Oct 20, 2020 · 0 comments · Fixed by #344
Assignees
Labels
enhancement Improving existing functionality

Comments

@alexvanin
Copy link
Contributor

alexvanin commented Oct 20, 2020

With new protubuf API v2 there is a updated protoc-gen-go-grpc package to generate GRPC code. It should be updated one day with something like this:

protoc \
	--proto_path=.:./vendor:./vendor/github.com/nspcc-dev/neofs-api:/usr/local/include \
	--go_out=. --go_opt=paths=source_relative \
	--go-grpc_opt=require_unimplemented_servers=false \
	--go-grpc_out=. --go-grpc_opt=paths=source_relative $$f; \

See https://github.com/grpc/grpc-go/blob/master/cmd/protoc-gen-go-grpc/README.md for details on require_unimplemented_servers=false option.

Based on #173

@cthulhu-rider cthulhu-rider self-assigned this Sep 28, 2021
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 28, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 29, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 29, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Sep 29, 2021
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants