Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON converters for container and acl structures #173

Merged
merged 8 commits into from
Oct 20, 2020

Conversation

alexvanin
Copy link
Contributor

With neofs-api v2.0.1 release we have more JSON name attributes and rich documentation. To use JSON representation of container and extended ACL in neofs-cli we have to update neofs-api-go library.

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #173 into master will increase coverage by 2.40%.
The diff coverage is 40.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   38.38%   40.78%   +2.40%     
==========================================
  Files          71       74       +3     
  Lines        8219     8284      +65     
==========================================
+ Hits         3155     3379     +224     
+ Misses       4625     4435     -190     
- Partials      439      470      +31     
Impacted Files Coverage Δ
v2/acl/types.go 80.00% <ø> (+40.00%) ⬆️
v2/object/marshal.go 59.06% <0.00%> (ø)
v2/refs/marshal.go 56.45% <0.00%> (ø)
v2/acl/json.go 38.46% <38.46%> (ø)
v2/container/json.go 38.46% <38.46%> (ø)
v2/netmap/json.go 38.46% <38.46%> (ø)
pkg/acl/eacl/target.go 100.00% <100.00%> (ø)
v2/acl/convert.go 70.54% <100.00%> (+35.27%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a69a89...007eb25. Read the comment docs.

realloc
realloc previously approved these changes Oct 20, 2020
Copy link

@realloc realloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Alex Vanin <alexey@nspcc.ru>
According to new neofs-api target filed `key_list`
rename to `keys`.

Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
@alexvanin alexvanin merged commit e6035a3 into nspcc-dev:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants