client: Add several replication improvements #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, signature field length was not added to the total size. While message was still correctly formed, this caused definite reallocation. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
It was added accidentally and affected nothing. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Object ID verifies its whole structure, so it's enough to sign it the ID to reduce resource consumption for creating/checking a request without losing security. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
requested review from
roman-khimov,
smallhive and
carpawell
as code owners
carpawell
approved these changes
Mar 5, 2024
roman-khimov
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.