Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: Add several replication improvements #565

Merged
merged 3 commits into from
Mar 5, 2024
Merged

client: Add several replication improvements #565

merged 3 commits into from
Mar 5, 2024

Commits on Mar 5, 2024

  1. client: Fix Replication request size calculation 

    Previously, signature field length was not added to the total size.
While message was still correctly formed, this caused definite
reallocation.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
    @cthulhu-rider
    cthulhu-rider committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e84898e View commit details
    Browse the repository at this point in the history

  2. client: Drop useless unary plus operator 

    It was added accidentally and affected nothing.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
    @cthulhu-rider
    cthulhu-rider committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    94c4904 View commit details
    Browse the repository at this point in the history

  3. client/replicate: Sign ID instead of the full object 

    Object ID verifies its whole structure, so it's enough to sign it the ID
to reduce resource consumption for creating/checking a request without
losing security.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
    @cthulhu-rider
    cthulhu-rider committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    3f513ed View commit details
    Browse the repository at this point in the history