Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new warning when using .Throws() when mocking a method returning a Task #164

Closed
Socolin opened this issue Aug 27, 2021 · 0 comments · Fixed by #178
Closed

Add a new warning when using .Throws() when mocking a method returning a Task #164

Socolin opened this issue Aug 27, 2021 · 0 comments · Fixed by #178
Assignees
@tpodolak
Labels
enhancement New feature or request
Milestone
1.0.16

Comments

@Socolin
Copy link

Socolin commented Aug 27, 2021

Hello,

I think it would be nice to have a warning when using .Throws() on a method returning a Task instead of .Returns(Task.FromException) (or maybe ThrowsAsync when available Related to: nsubstitute/NSubstitute#609)

This would help to mock exception correctly on async methods.
@tpodolak tpodolak added the enhancement New feature or request label Aug 27, 2021
tpodolak added a commit that referenced this issue Jan 5, 2022
@tpodolak
GH-164 - throws used in async method diagnostic
892034e
tpodolak added a commit that referenced this issue Jan 5, 2022
@tpodolak
[GH-164] - async throws fix provider
bb94d53
tpodolak added a commit that referenced this issue Jan 5, 2022
@tpodolak
[GH-164] - async throws fix provider
999213c
tpodolak added a commit that referenced this issue Jan 5, 2022
@tpodolak
[GH-164] - async throws fix provider
c8670ad
tpodolak added a commit that referenced this issue Jan 5, 2022
@tpodolak
[GH-164] - async throws fix provider
773e419
@tpodolak tpodolak mentioned this issue Jan 5, 2022
Merged
tpodolak added a commit that referenced this issue Jan 5, 2022
@tpodolak
[GH-164] - async throws fix provider
1025814
@tpodolak tpodolak self-assigned this Jan 8, 2022
tpodolak added a commit that referenced this issue Jan 16, 2022
@tpodolak
GH-164 - throws used in async method diagnostic
d7f7ace
tpodolak added a commit that referenced this issue Jan 16, 2022
@tpodolak
[GH-164] - async throws fix provider
2a25f31
tpodolak added a commit that referenced this issue Jan 16, 2022
@tpodolak
Merge pull request #178 from nsubstitute/GH-164-throws
638d92a 
GH-164 sync throws used in asyc method
@tpodolak tpodolak added this to the 1.0.16 milestone Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpodolak tpodolak

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.16
Development

Successfully merging a pull request may close this issue.

GH-164 sync throws used in asyc method nsubstitute/NSubstitute.Analyzers
2 participants
@Socolin @tpodolak