Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-164 sync throws used in asyc method #178

Merged
merged 2 commits into from
Jan 16, 2022
Merged

GH-164 sync throws used in asyc method #178

merged 2 commits into from
Jan 16, 2022

Conversation

tpodolak
Copy link
Member

@tpodolak tpodolak commented Jan 5, 2022

closes #164
SyncThrows

tpodolak
tpodolak commented Jan 5, 2022
View reviewed changes
src/NSubstitute.Analyzers.Shared/Resources.resx Outdated
@@ -409,4 +409,13 @@
<value>Non-virtual setup specification.</value>
<comment>The title of the diagnostic.</comment>
</data>
<data name="SyncOverAsyncThrowsDescription" xml:space="preserve">
<value>Sync throws used in async method.</value>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dtchepak are you ok with this message?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tpodolak LGTM 👍 Maybe "Synchronous exception thrown from async method" would be a bit clearer but more verbose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, changed

@coveralls
Copy link

coveralls commented Jan 5, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 467

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 95.691%
Files with Coverage Reduction New Missed Lines %
C/projects/nsubstitute-analyzers/src/NSubstitute.Analyzers.Shared/Extensions/SubstituteSymbolExtensions.cs 1 96.55%
C/projects/nsubstitute-analyzers/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractSubstitutionNodeFinder.cs 3 91.18%
Totals Coverage Status
Change from base Build 466: -0.1%
Covered Lines: 2709
Relevant Lines: 2831
💛 - Coveralls

@tpodolak tpodolak merged commit 638d92a into dev Jan 16, 2022
@tpodolak tpodolak deleted the GH-164-throws branch January 16, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtchepak dtchepak dtchepak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new warning when using .Throws() when mocking a method returning a Task
3 participants
@tpodolak @coveralls @dtchepak