Fix: BNavbar crash with "TypeError: this.$slots.brand is not a function" (#28) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes the bug where an empty `BNavbar` crashed with "TypeError: this.$slots.brand is not a function". Checks if `this.$slots.brand` is not nullish before calling it. issue ntohq#28
wesdevpro
approved these changes
Aug 14, 2023
src/components/navbar/Navbar.vue
Outdated
| @@ -168,10 +168,16 @@ export default { | |||
| ]) | |||
| }, | |||
| genNavbarBrandNode() { | |||
| let children | |||
There was a problem hiding this comment.
Does this look better?
const children = this.$slots.brand != null
? [this.$slots.brand(), this.genBurgerNode()]
: this.genBurgerNode()There was a problem hiding this comment.
You can also add parentheses to make the conditional expression more clear in the ternary operation
const children = (this.$slots.brand != null)
? [this.$slots.brand(), this.genBurgerNode()]
: this.genBurgerNode()
wesdevpro
requested changes
Aug 16, 2023
src/components/navbar/Navbar.vue
Outdated
| @@ -168,10 +168,16 @@ export default { | |||
| ]) | |||
| }, | |||
| genNavbarBrandNode() { | |||
| let children | |||
src/components/navbar/Navbar.vue
Outdated
| @@ -168,10 +168,16 @@ export default { | |||
| ]) | |||
| }, | |||
| genNavbarBrandNode() { | |||
| let children | |||
There was a problem hiding this comment.
You can also add parentheses to make the conditional expression more clear in the ternary operation
const children = (this.$slots.brand != null)
? [this.$slots.brand(), this.genBurgerNode()]
: this.genBurgerNode()- Regarding the conversation: ntohq#30 (comment)
kikuomax
commented
Aug 21, 2023
| @@ -168,10 +168,13 @@ export default { | |||
| ]) | |||
| }, | |||
| genNavbarBrandNode() { | |||
| const children = this.$slots.brand != null | |||
| ? [this.$slots.brand(), this.genBurgerNode()] | |||
| : this.genBurgerNode() | |||
There was a problem hiding this comment.
@wesdevpro I believe the updated code is legible enough and aligns with the style of the other part of the codebase.
wesdevpro
approved these changes
Aug 21, 2023
|
@kikuomax please pull the changes into dev. For some reason I can't create a merge and commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Proposed Changes
this.$slots.brandis not nullish before calling it