Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: BNavbar crash with "TypeError: this.$slots.brand is not a function" (#28) #30

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Fix: BNavbar crash with "TypeError: this.$slots.brand is not a function" (#28) #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93b8661
fix(lib): crash of empty BNavbar
kikuomax Aug 14, 2023
2fb278d
style(lib): change coding style in Navbar
kikuomax Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/navbar/Navbar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,13 @@ export default {
])
},
genNavbarBrandNode() {
const children = this.$slots.brand != null
? [this.$slots.brand(), this.genBurgerNode()]
: this.genBurgerNode()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesdevpro I believe the updated code is legible enough and aligns with the style of the other part of the codebase.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✨

return createElement(
'div',
{ class: 'navbar-brand' },
[this.$slots.brand(), this.genBurgerNode()]
children
)
},
genBurgerNode() {
Expand Down