Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to symfony ^6.4 || ^7.0 #600

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Bump to symfony ^6.4 || ^7.0 #600

merged 3 commits into from
Feb 25, 2024

Conversation

core23
Copy link
Member

@core23 core23 commented Feb 4, 2024

There is a soft BC break on Nucleos\UserAdminBundle\Security\Authorization\Voter\UserAclVoter.

The voter does not extend Symfony\Component\Security\Acl\Voter\AclVoter anymore and implements Symfony\Component\Security\Core\Authorization\Voter\VoterInterface directly. As the old parent class does not provide any other public interface, there should be no problem as long as you don't check for inheritance in the code.

@core23 core23 added this to the 3.4.0 milestone Feb 4, 2024
@core23 core23 requested a review from nucleos-bot as a code owner February 4, 2024 17:13
@core23 core23 force-pushed the symfony7 branch 4 times, most recently from a4b31d9 to 944e785 Compare February 4, 2024 17:24
@core23
Copy link
Member Author

core23 commented Feb 9, 2024

Depends on symfony/security-acl#116

@core23 core23 merged commit 534ae96 into nucleos:3.4.x Feb 25, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant