Fix Symfony 7 compatibility #116
Conversation
core23
force-pushed
the
symfony7
branch
4 times, most recently
from
ff4faca to
4f067d9
Compare
|
Is there anything left to do? This blocks symfony 7 updates :( |
Friendly ping @nicolas-grekas maybe (?) |
|
Two ✅ Can be merge this @nicolas-grekas ? |
|
@core23 Thanks for working on the symfony 7 compatibility. I stumbled upon this and saw that checks are failing due to deprecations. I was able to fix them locally. I could provide a separate PR, but wouldn't it be better to provide the code to you? Should I create a PR in your fork which you then can merge in your symfony7 branch? |
|
AFAIK they are not related to this PR, so it would be better to fix this deprecation issues on the main project first. |
I will do that, thanks. |
|
@core23 I just had a look. As the current tagged version is 3.3.3, which bumped Symfony up to 7, I cannot fix the deprecation warnings without fixing the return type declarations too, which are part of your PR :) |
|
@nicolas-grekas Hi Nicolas, could you maybe help out? How should we proceed with the deprecation warnings? I could either bump up the code to the current implementation, but then the lowest versions are not supported anymore. Or do we disable deprecations on the highest versions? |
|
Hi all, any news on this? |
|
I created a new PR that includes this commit and fixes all builds #121 |
This PR was merged into the 3.x-dev branch. Discussion ---------- Fix Symfony 7 compatibility Continuation of #116 I want to see what is failing to fix it. Might close: #112 #115 #114 #121 Commits ------- 17f2255 Actualizar AclVoter.php 29379e6 fix cs issues c4c7ca0 suppress psalm since it is not fixable 1247ccb Fix tests 8647e14 Fix symfony 7 compatibility
|
Merged via #121 |
Fixes #114 by providing the correct method signature, depending on the loaded
symfony/security-coreversion.Might close: #112 #115 #114