refactor: remove some unsafe (#20)

bindings/wasm/src/lib.rs

@@ -1,6 +1,6 @@
-#![allow(non_snake_case, dead_code)]
+#![allow(non_snake_case)]
 
-use std::{convert::AsRef, mem::transmute, ops::Range};
+use std::{convert::AsRef, ops::Range};
 use wasm_bindgen::prelude::*;
 
 #[wasm_bindgen]
@@ -27,7 +27,7 @@ impl CuredString {
     Match {
       start: mat.start,
       end: mat.end,
-      portion: String::from(unsafe { self.0.get_unchecked(mat) }),
+      portion: String::from(&self.0[mat]),
     }
   }
 
@@ -83,7 +83,7 @@ impl CuredString {
 
 #[wasm_bindgen]
 pub fn cure(input: &str, options: u32) -> Result<CuredString, JsError> {
-  match decancer::cure(input, unsafe { transmute(options) }) {
+  match decancer::cure(input, options.into()) {
     Ok(output) => Ok(CuredString(output)),
     Err(err) => Err(JsError::new(<decancer::Error as AsRef<str>>::as_ref(&err))),
   }

core/build.rs

@@ -1,3 +1,4 @@
 fn main() {
+  println!("cargo:rerun-if-changed=bin/bidi.bin");
   println!("cargo:rerun-if-changed=bin/codepoints.bin");
 }

core/src/options.rs

@@ -1,8 +1,6 @@
 use crate::{codepoints::Codepoint, Translation};
 use paste::paste;
 use std::cmp::Ordering;
-#[cfg(feature = "options")]
-use std::mem::transmute;
 
 /// A configuration struct where you can customize decancer's behavior.
 ///
@@ -126,11 +124,10 @@ impl Options {
   }
 
   #[cfg(feature = "options")]
-  #[allow(clippy::transmute_int_to_bool)]
   pub(crate) const fn refuse_cure(self, attributes: u8) -> bool {
     let locale = attributes >> 1;
 
-    (unsafe { transmute(attributes & 1) } && self.is(2)) || (locale > 2 && self.is(locale))
+    ((attributes & 1) != 0 && self.is(2)) || (locale > 2 && self.is(locale))
   }
 
   pub(crate) const fn translate(self, code: u32, offset: i32, mut end: i32) -> Option<Translation> {
@@ -160,3 +157,12 @@ impl Options {
     None
   }
 }
+
+#[doc(hidden)]
+#[cfg(feature = "options")]
+impl From<u32> for Options {
+  #[inline(always)]
+  fn from(value: u32) -> Self {
+    Self(value)
+  }
+}

core/src/string.rs

@@ -6,7 +6,6 @@ use crate::{
 use serde::{de, Deserialize, Deserializer, Serialize, Serializer};
 use std::{
   fmt::{self, Debug, Display, Formatter},
-  mem::transmute,
   ops::{Deref, Range},
 };
 
@@ -18,12 +17,6 @@ use std::{
 pub struct CuredString(pub(crate) String);
 
 impl CuredString {
-  #[deprecated(since = "3.1.2", note = "use .into() instead")]
-  #[inline(always)]
-  pub fn into_str(self) -> String {
-    self.into()
-  }
-
   /// Iterates throughout this string and yields every similar-looking match.
   ///
   /// If you plan on using this method with an array of strings, use [`find_multiple`][CuredString::find_multiple].
@@ -78,9 +71,7 @@ impl CuredString {
 
     for mat in matches {
       // SAFETY: mat is always within the mat of self
-      let chars = unsafe { original.get_unchecked(mat.clone()) }
-        .chars()
-        .count();
+      let chars = original[mat.clone()].chars().count();
       let mut with_str = String::with_capacity(chars);
 
       for _ in 0..chars {
@@ -224,8 +215,7 @@ impl CuredString {
 impl From<CuredString> for String {
   #[inline(always)]
   fn from(val: CuredString) -> Self {
-    // SAFETY: see definition of CuredString
-    unsafe { transmute(val) }
+    val.0
   }
 }