Remove usage of unsafe completely

[Milo123459]

There is no reason for this crate to use unsafe code.

[null8626]

Would this be possible though? Because the crate also reads from a custom-made binary - which wouldn't be possible without some pointer arithmetic.

[null8626]

I'm afraid this is a wontfix, sorry.
The SAFETY comments and lots of testing should suffice!

[GnomedDev]

As seen by #24, safety comments and testing without miri will not make unsafe magically safe. I'm preparing a PR to remove the trivial unsafe, is there an acceptable performance loss or must it be 1-1? @null8626.

[null8626]

Hmm, alright then, do as you please!

A slight performance loss is fine.

[null8626]

Hai! Any updates on this?

[null8626]

Sooo i've removed all unsafe code in the Rust, WebAssembly, and Node.js crates today! Some unsafe still persists in the Java and C/C++ crates as they are a cdylib in nature.

Feel free to give me feedback on the current codebase! @GnomedDev @Milo123459

[Milo123459]

I think the next step would just be publishing a new release :)

[null8626]

A new release should be out later this month!

Thank you all for the advice! I will be more cautious with unsafe code. I apologize for closing this issue prematurely! ❤️

[null8626]

The update is here!