Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py312 via aorg #7

Merged
merged 9 commits into from
Jan 17, 2024
Merged

Py312 via aorg #7

merged 9 commits into from
Jan 17, 2024

Conversation

esc
Copy link
Member

@esc esc commented Sep 14, 2023

No description provided.

@esc
Copy link
Member Author

esc commented Sep 14, 2023

This is based off of #6 but uses the files from anaconda.org instead of the 3.12 build from the python docker containers.

@esc
Copy link
Member Author

esc commented Sep 14, 2023

Like #6 this ends at:

numba/_dispatcher.cpp: In function 'int call_trace(Py_tracefunc, PyObject*, PyThreadState*, PyFrameObject*, int, PyObject*)':
numba/_dispatcher.cpp:53:28: error: 'PyThreadState' {aka 'struct _ts'} has no member named 'tracing_what'
   53 |     int old_what = tstate->tracing_what;
      |                            ^~~~~~~~~~~~
numba/_dispatcher.cpp:54:13: error: 'PyThreadState' {aka 'struct _ts'} has no member named 'tracing_what'
   54 |     tstate->tracing_what = what;
      |             ^~~~~~~~~~~~
numba/_dispatcher.cpp:58:13: error: 'PyThreadState' {aka 'struct _ts'} has no member named 'tracing_what'
   58 |     tstate->tracing_what = old_what;
      |             ^~~~~~~~~~~~
numba/_dispatcher.cpp: In function 'PyObject* call_cfunc(Dispatcher*, PyObject*, PyObject*, PyObject*, PyObject*)':
numba/_dispatcher.cpp:658:25: error: '_PyCFrame' {aka 'struct _PyCFrame'} has no member named 'use_tracing'
  658 |     if (tstate->cframe->use_tracing && tstate->c_profilefunc)
      |                         ^~~~~~~~~~~
In file included from /opt/miniconda/envs/buildenv/include/python3.12/Python.h:78,
                 from numba/_pymodule.h:6,
                 from numba/_dispatcher.cpp:1:
/opt/miniconda/envs/buildenv/include/python3.12/pystate.h:63:46: warning: control reaches end of non-void function [-Wreturn-type]
   63 | #define PyThreadState_GET() PyThreadState_Get()
      |                             ~~~~~~~~~~~~~~~~~^~
numba/_dispatcher.cpp:650:14: note: in expansion of macro 'PyThreadState_GET'
  650 |     tstate = PyThreadState_GET();
      |              ^~~~~~~~~~~~~~~~~

As title
@esc
Copy link
Member Author

esc commented Sep 15, 2023

This has now been cleaned up and is ready for review. The main change is that now bootstraping via anaconda.org is also supported. The makefile now has *-pypi and *-aorg targets that can be used to trigger the compilation pipeline for PyPi or for anaconda.org packages respectively.

As title
@esc esc requested a review from kc611 September 15, 2023 14:29
@esc
Copy link
Member Author

esc commented Sep 18, 2023

Note to self, we can probably use the images at: https://hub.docker.com/u/continuumio instead of bootstrapping our own.

@esc esc mentioned this pull request Sep 29, 2023
@esc esc merged commit 21ccd48 into numba:main Jan 17, 2024
@esc esc deleted the py312_via_aorg branch January 17, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant