Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 #9197

Closed
esc opened this issue Sep 14, 2023 · 22 comments
Closed

Python 3.12 #9197

esc opened this issue Sep 14, 2023 · 22 comments
Labels
Python 3.12 Python 3.12 related
Milestone

Comments

@esc
Copy link
Member

esc commented Sep 14, 2023

This ticket tracks overall progress of Python 3.12 support for Numba.

@esc esc added the Python 3.12 Python 3.12 related label Sep 14, 2023
@esc esc added this to the 0.59.0-rc1 milestone Sep 14, 2023
@esc esc pinned this issue Sep 14, 2023
@esc
Copy link
Member Author

esc commented Sep 14, 2023

A numba-hatchery based build using the python docker container is here:

numba/numba-hatchery#6

@esc
Copy link
Member Author

esc commented Sep 29, 2023

A miniconda based variant of the hatchery is now here: numba/numba-hatchery#7 -- @kc611 @sklam @stuartarchibald and I are using this to port Numba to 3.12. I have begun to start collecting patches in my branch:

https://github.com/esc/numba/commits/py312

Note that this branch is still very much subject to frequent rebases, so do bear that in mind should you base anything off of it.

For those wondering about our timeline. A significant portion of the tests is working already and we are continuing to solve the issues we encounter from running the test-suite. At this stage things are looking OK, but Numba will not compatible from day 1 of the 3.12 release. As with 3.10 and 3.11 a Numba release supporting 3.12 will become available some time after the official release of 3.12.

@detrin
Copy link

detrin commented Oct 12, 2023

I would love to see support for python3.12

@esc
Copy link
Member Author

esc commented Oct 12, 2023

I would love to see support for python3.12

Yes, it's coming, soon. As of today, we are at around 98% of the test-suite passing and have roughly 100 failing tests left to fix.

@esc
Copy link
Member Author

esc commented Oct 17, 2023

A draft PR has been opened: #9246 -- currently some tests are still failing, but the branch is OK enough for early testing.

@rupeshknn
Copy link

what's the ETA on this?

@esc
Copy link
Member Author

esc commented Oct 27, 2023

what's the ETA on this?

Couple of weeks. According to my latest calculations, we are now at 12 errors and 28 failures remaining.

Zeitsperre added a commit to Ouranosinc/xclim that referenced this issue Jan 22, 2024
### What kind of change does this PR introduce?

* Adds the `numba` release candidate repository to the
`environment.yml`.
* Stages changes to the `main.yml` workflows to test for dependency
resolution.
* Adjusts `tox.ini` to install release candidate of `numba` (`"numba"` modifier).
* Updates package metadata.

### Does this PR introduce a breaking change?

No.

### Other information:

`xclim` running under Python3.12 with numba v0.59.0rc1 is testing
without issues locally.

See: numba/numba#9197
@sklam sklam unpinned this issue Jan 31, 2024
@sklam sklam pinned this issue Jan 31, 2024
@kc611
Copy link
Contributor

kc611 commented Feb 2, 2024

Pleased to announce that Numba 0.59.0 has been tagged and released along with official support for Python 3.12. 🎉

Closing this issue in accordance to the above.

@paddyroddy
Copy link

Pleased to announce that Numba 0.59.0 has been tagged and released along with official support for Python 3.12. 🎉

It doesn't seem to have been made into a release

@jorenham
Copy link

jorenham commented Feb 6, 2024

@paddyroddy Not on github, no. But it is available on pypi.

@jamesmyatt
Copy link

@paddyroddy Not on github, no. But it is available on pypi.

and conda-forge 👍

@esc
Copy link
Member Author

esc commented Feb 7, 2024

@paddyroddy we don't prioritize releases on GitHub at the moment and crafting one is part of the post-release actions:

#9410

I've now fixed that:

https://github.com/numba/numba/releases/tag/0.59.0

And it's available:

Screenshot 2024-02-07 at 10 26 21

@paddyroddy is this what you were asking about? Should we include making a "github-release" as part of the official release process rather than it being a post-release action? So far, there seems to have been little interest in "github-releases", but perhaps that is changing now?

@esc esc mentioned this issue Feb 7, 2024
34 tasks
@paddyroddy
Copy link

@esc I was merely wondering if it was an oversight. Personally, I don't mind either way. With my packages I usually make a release, which in itself pushes to PyPI - but my packages are far more trivial than numba, so I appreciate that it might not be possible that way.

@esc
Copy link
Member Author

esc commented Feb 7, 2024

@esc I was merely wondering if it was an oversight. Personally, I don't mind either way. With my packages I usually make a release, which in itself pushes to PyPI - but my packages are far more trivial than numba, so I appreciate that it might not be possible that way.

Yes, I see, indeed our release process is quite complex. It involves several days of overnight testing and compiling packages on bare metal hardware and so on. We wouldn't be able to "just" make a GitHub release and have that be pushed to PyPi unfortunately. IIRC the delay of the "GitHub release" was mentioned as a criticism a few times before, so I will lobby to make that part of the release process, rather than it being a post-release action. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python 3.12 Python 3.12 related
Projects
None yet
Development

No branches or pull requests

10 participants