CI against Python 3.12

[jGaboardi]

This PR:

• starts testing against Python 3.12
• drop Python 3.8 & 3.9 support
• cleans up dips / req in pyproject.toml, ci/*, and environment.yml

---

Current situation:

• 3.10 & 3.11
  • all good
• 3.12
  • Not quite there – numba can't be resolved yet but this seems like it will be good to go soon.

[jGaboardi]

• Python 3.12 passing with no options
• Other versions failing with known issues with latest networkx release (see here in graph._set_ops.isomorphic())
  • xref avoid could_be_isomorphic on nx 3.2 #586

[jGaboardi]

@martinfleis @sjsrey

Should we:

1. drop 3.8 + 3.9 and have 3.10 as minimal; or
2. only drop 3.8 and keep 3.9 as minimal

[sjsrey]

@martinfleis @sjsrey

Should we:

1. drop 3.8 + 3.9 and have 3.10 as minimal; or

2. only drop 3.8 and keep 3.9 as minimal

If we follow spec 0, 3.10 would be minimal with 3.12 out now.

[sjsrey]

lgtm

[martinfleis]

Can we just comment-out numba from 3.12 envs for now and merge? We can revise once numba is available.

[jGaboardi]

Can we just comment-out numba from 3.12 envs for now and merge? We can revise once numba is available.

This sounds reasonable. I will do that and push up.

Also, I am working on #588 right now. Shall I incorporate that into this PR or in another?

[martinfleis]

Let's do it as a follow-up. That one will likely see some code changes.

[jGaboardi]

• ci/312-dev failing due to
  • xref --> TST: fix alpha_shape failures on dev #587
  • xref --> BUG: fix interiors when no interior is present geopandas/geopandas#3047
• Intersting libpysal version --> Successfully installed libpysal-0.1.dev1+g344cccc

[codecov]

Codecov Report

Merging #585 (a45e153) into main (0ea928a) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #585   +/-   ##
=====================================
  Coverage   84.0%   84.0%           
=====================================
  Files        128     128           
  Lines      15054   15053    -1     
=====================================
  Hits       12642   12642           
+ Misses      2412    2411    -1     

see 1 file with indirect coverage changes

[jGaboardi]

@martinfleis this is now ready for review.

[martinfleis]

Intersting libpysal version --> Successfully installed libpysal-0.1.dev1+g344cccc

We need to ensure the tags are present. This may cause trouble. We need

- uses: actions/checkout@v4
    with:
        fetch-depth: 0 # Fetch all history for all branches and tags.

[jGaboardi]

Add to this PR, correct?

[martinfleis]

Yes please :)

[jGaboardi]

I guess now we need to check across the ecosystem for that...

[jGaboardi]

Seeing the proper libpysal version now.

• before: libpysal-0.1.dev1+g344cccc
• now: libpysal-4.8.1.dev19+gbb16a5eb

All passing with the exception of the known failure. The last commit to properly indent the build_docs action didn't trigger CI for some reason, but now the syntax is correct there.

[jGaboardi]

Once this is reviewed & merged I will tackle #588.

[martinfleis]

Looks great! Thanks!

I got a branch tackling most of the warnings in CI, so that should also be resolved shortly.

[martinfleis]

@jGaboardi Why did we include xarray as a hard dependency here? Is that because we actually hard depend on it? If so we should refactor. Something around that is causing conda-forge to fail.

[jGaboardi]

I suppose that was my oversight/mistake since there is a from_xarray() method in weights/contiguity.py and xarray is imported weights/raster.py. However, these are clearly not hard deps.

I will put in a PR to fix this immediatly.