Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlalchemy and geomet #588

Closed
jGaboardi opened this issue Oct 21, 2023 · 3 comments · Fixed by #592
Closed

sqlalchemy and geomet #588

jGaboardi opened this issue Oct 21, 2023 · 3 comments · Fixed by #592
Assignees
Labels
dependencies Pull requests that update a dependency file maintenance

Comments

@jGaboardi
Copy link
Member

Both sqlalchemy and geomet were removed from requirements in #579, sqlalchemy by accident and geomet on purpose.

@jGaboardi jGaboardi added maintenance dependencies Pull requests that update a dependency file labels Oct 21, 2023
@jGaboardi jGaboardi self-assigned this Oct 21, 2023
@jGaboardi
Copy link
Member Author

@martinfleis I think this whole block below can go, no? shapley is now a hard dependency and geomet is gone.

try:
try:
from geomet import wkb
except ImportError:
from shapely import wkb
except ImportError:
wkb = None
errmsg += "No WKB parser found. Please install one of the following packages "
errmsg += "to enable this functionality: [geomet, shapely].\n"

@martinfleis
Copy link
Member

Yes, we should use shapely by default.

@jGaboardi
Copy link
Member Author

The Test_sqlite_reader test is causing trouble due to this helper fucntion. Going to refactor the test to ensure passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants