-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: dealing with sqlalchemy
& geomet
#592
Conversation
Codecov Report
@@ Coverage Diff @@
## main #592 +/- ##
=======================================
+ Coverage 84.2% 84.5% +0.3%
=======================================
Files 128 128
Lines 15080 15069 -11
=======================================
+ Hits 12698 12734 +36
+ Misses 2382 2335 -47
|
sqlalchemy &
geomet`sqlalchemy
& geomet
sqlalchemy
& geomet
sqlalchemy
& geomet
Seems to be an OS-specific failure:
|
This is actually happening in the
Probably can simply move |
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
Welp, not really sure why we are still seeing the |
Skip it on win. I suppose that this code will eventually go anyway. You can probably replace it with geopandas read_sql or read SQL with GDAL via pyogrio or fiona, all of which are way more maintained than our |
I'll just implement the skip for now. Better to do baby steps. |
We've got 100% green CI! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR resolves #588