Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added diagonal dominance functions, update src #128

Merged
merged 1 commit into from
Oct 9, 2014
Merged

added diagonal dominance functions, update src #128

merged 1 commit into from
Oct 9, 2014

Conversation

Dakkers
Copy link
Contributor

@Dakkers Dakkers commented Oct 9, 2014

yep:

  • added isRowDD, isColumnDD, isStrictlyRowDD, isStrictlyColumnDD; these functions are useful for numerical stability-related junk.
  • wrote appropriate tests
  • made matrix.zeros better (realized I originally use Array.push() instead of allocating the right amount of memory using new Array(n)
  • updated src/ (the new implementation of the "naive" prime function was not updated in the source)

cc @LarryBattle

@Dakkers Dakkers mentioned this pull request Oct 9, 2014
@KartikTalwar
Copy link
Member

LGTM

Dakkers added a commit that referenced this pull request Oct 9, 2014
added diagonal dominance functions, update src
@Dakkers Dakkers merged commit dd2066c into numbers:master Oct 9, 2014
@Dakkers
Copy link
Contributor Author

Dakkers commented Oct 10, 2014

@LarryBattle :

I've noticed that we're kind of hacky with the square matrix checking. most functions we have don't actually use matrix.isSquare(M) to check if it's a matrix, we just check the first row and hope that the user didn't enter it incorrectly. we should be checking properly. I'll fix this today. a lot of functions also throw the exact same errors, so we could have a private function throw an error if needed.

as for the private method for the for-loops, that's reasonable too. I'll throw that in today as well.

sorry for jumping the gun!

@Dakkers
Copy link
Contributor Author

Dakkers commented Oct 10, 2014

there's also a lot of inconsistency with the way errors are thrown. I'll be fixing that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants