formatted errors, factored code #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @LarryBattle |
|
Looks good. |
|
right right, will update the exports. most of the code thus far is written like that. I agree it is weird but I would rather be consistent (as it stands now) and kinda weird than have to rewrite all of the error-throwing blocks. although maybe we could just use jsfmt, if it supports that kind of thing. |
|
@LarryBattle I'm going to merge this for now because I want to get the linalg functions started. we can come back to this later if need be. |
Dakkers
added a commit
that referenced
this pull request
Nov 2, 2014
formatted errors, factored code
|
Sounds good. I'll try to help out if I have sometime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additions to #128 . I probably forgot to update the src/ at the very end, shit.