Squashed everything from numenta/nupic#364 into nupic.core #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much @oxtopus ! I wouldn't know how to do that automatically. 👍 Until the tests are in place, I'll test locally here. Btw 1: I think I'll need help from @david-ragazzi when you have time.. The changes to Btw 2: the former PR touches C++ files outside of |
|
@breznak Those files are python language bindings created by SWIG, I believe. They will stay in the |
|
Ok, thanks Matt. I'll keep that as a TODO, as those need to be changed too for the PR to work. |
|
Added oxtopus#1 that merges master changes into this remote branch. I'd like to see what Travis says about this now. |
|
@rhyolight I'm closing this. Can you pick it up with master merged in your fork instead? |
rhyolight
pushed a commit
to rhyolight/nupic.core
that referenced
this pull request
Jul 1, 2014
Merge Matt's Google test branch
scottpurdy
pushed a commit
to scottpurdy/nupic.core
that referenced
this pull request
Oct 20, 2015
Updating master
2 tasks
breznak
added a commit
to breznak/nupic.core
that referenced
this pull request
Dec 1, 2018
* Likelihood: initial implementation of Anomaly Likelihood. The python version used as reference. * MovingAverage: add getter for max window size getMaxSize() * Likelihood: simplify & cleanup design * Likelihood: use circular_buffers * Likelihood: use boost::circular_buffer * remove old comment * Likelihood: review 1 - fix include accumulate, inner_product from <numeric> which is needed to be included on some systems explicitely * Likelihood: review 1- fix min needs cast to ulong for both params for Win/AppVeynor * Likelihood: review 1 - fix assert * Likelihood: add header file * Anomaly: add Likelihood implementation implements mode::LIKELIHOOD, mode::WEIGHTED * Anomaly: fix uninitialized var likelihood * Likelihood: initial test * Likelihood: fix header separation * Likelihood: update first test * review 1: Anomaly: fix likelihood score as (1-likelihood) * Likelihood: review 2: remove rawValue as input to the Likelihood code, along with the "hack" from python. * MovingAverage: rev2: rename to getMaxWindowSize() from getMaxSize(); used in Likelihood * Likelihood: rev2: move mean/var helpers to cpp only not defined in header * Likelihood: rev2: use NTA_CHECK * Likelihood: rev2: move docs to header file * Likelihood rev2: cast to UInt * Likelihood: fix filterLikelihoods() where new array would have size +1, now the sizes are correctly the same. Also changes/simplifies the method of IFs there * Likelihood: rev2: optimize vector allocation using resize(), and add security checks * Likelihood: TMP comment out offending check fix that! * Likelihood: add FIXME about (not) using timestamps * Likelihood: fix reserve instead of resize * Likelihood: forgoten fixes * Likelihood: replace some magic numbers with constants * Likelihood: use trailing _ for private methods & members * Move circularBufferToWindow() from header to cpp only * Likelihood: move calcSkipRecords_ from header to cpp * Likelihood: make computeLogLikelihood public as requested for visualizations, ... * Likelihood: remove nullDistribution() as it's only used once * Anomaly: drop (raw) inputValue as it's not used * Anomaly: use Real instead of Real32 * Anomaly: align timestamp (int, default -1) with Likelihood * Likelihood: use Real instead of Real32 * Likelihood: check timestamp is monotonically increasing * Likelihood: honor timestamp uses timestamp if applicable, * Likelihood: make public const members public * Likelihood: fix runningLikelihood always pushed 0.5 * Likelihood: fix formating of docstrings * Likelihood: doc estimateNormal() takes raw anomalyScores * Likelihood: optimize: use const, pass reference& where applicable * Likelihood: TODO comment on aggregation * Likelihood: fix typo * Likelihood: fix CI error in assert * Likelihood: fix runningLikelihoods size dont insert elsewhere in the code. Needs review if valid change * Anomaly: fix merge duplicate code * AnomalyLikelihood: replace boost::circular_buffer with SlidingWindow * Numenta copyright not needed, retrigger build * Travis use gcc 7 * Revert "Travis use gcc 7" This reverts commit 64b2a13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @breznak re: #8 and numenta/nupic-legacy#364