Nupic core silence warnings

[rhyolight]

Replaces #11.

[subutai]

Should we delete this rather than commenting it out?

[subutai]

Some minor comments, otherwise 👍 @rhyolight Did you test this out on OSX as well?

[rhyolight]

Will do now.

---

Matt Taylor
OS Community Flag-Bearer
Numenta

On Mon, Mar 3, 2014 at 10:22 AM, Subutai Ahmad notifications@github.comwrote:

Some minor comments, otherwise [image: 👍]@rhyolighthttps://github.com/rhyolightDid you test this out on OSX as well?

Reply to this email directly or view it on GitHubhttps://github.com//pull/34#issuecomment-36540513
.

[rhyolight]

@subutai Tested in OSX, and all is well there.

[subutai]

Great. Just those minor comments about removing comments, but otherwise good to merge.

[rhyolight]

@subutai Done, please merge. 🐺

[breznak]

@rhyolight Does Travis work on here, or you just go brave? 😉

[subutai]

@breznak It said the build had passed before I clicked the merge button. I hope this means Travis was working!!

[rhyolight]

Yes, Travis was passing.

---

Matt Taylor
OS Community Flag-Bearer
Numenta

On Tue, Mar 4, 2014 at 1:28 PM, Subutai Ahmad notifications@github.comwrote:

@breznak https://github.com/breznak It said the build had passed before
I clicked the merge button. I hope this means Travis was working!!

Reply to this email directly or view it on GitHubhttps://github.com//pull/34#issuecomment-36680166
.

[breznak]

Oh, sorry for noise guys! the design slightly changed and I thought it should show green even for merged PRs. 🍻

[subutai]

@breznak Actually one thing is true is that a passing build in nupic.core does NOT mean it will pass in nupic since all of the real tests are still in nupic. So it's definitely important to ensure tests pass locally first before merging!

[rhyolight]

Yes, absolutely. But we'll be able to do this in the nupic repo within a PR
that moves to the new version of the nupic.core submodule once we're ready
to use it.

---

Matt Taylor
OS Community Flag-Bearer
Numenta

On Tue, Mar 4, 2014 at 1:48 PM, Subutai Ahmad notifications@github.comwrote:

@breznak https://github.com/breznak Actually one thing is true is that
a passing build in nupic.core does NOT mean it will pass in nupic since
all of the real tests are still in nupic. So it's definitely important to
ensure tests pass locally first before merging!

Reply to this email directly or view it on GitHubhttps://github.com//pull/34#issuecomment-36682428
.

[subutai]

Ah ok. Tricky tricky 😃