Recover zconf.h in external
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Green and ready to merge. Hope to be reviewed and merged ASAP. #106 breaks the build on systems which doesn't have zlib development headers pre-installed, and worse, on systems which does have zlib development headers pre-installed but somehow not zconf.h . |
rhyolight
added a commit
that referenced
this pull request
Jun 7, 2014
Recover `zconf.h` in `external`
breznak
added a commit
to breznak/nupic.core
that referenced
this pull request
Nov 15, 2018
This removes the APR libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106, and is a follow up of what is missed by #97 to fix #48.
zlib.hinexternalcausing build problem #106 is reproduced on travis by 8429c20 , see the travis build for itzlib.hinexternalcausing build problem #106 is fixed by recoveringzconf.hfiles inexternalfrom numenta/nupic-legacy@1e60936, right before merging Independent Build Process #47 which caused Missing dependencyzlibor more inexternal/common/include#48 and thuszlib.hinexternalcausing build problem #106