Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent Build Process #47

Merged
merged 16 commits into from
Apr 3, 2014
Merged

Independent Build Process #47

merged 16 commits into from
Apr 3, 2014

Conversation

david-ragazzi
Copy link
Contributor

This commit includes the compilation of the dynamic/static libraries
that compose nupic.core. They are generated by default on
nupic.core/build/release folder, however any user could change its
destination using cmake -DPROJECT_BUILD_RELEASE_DIR:STRING=… or cmake -DPROJECT_BUILD_TEMP_DIR:STRING=… command line.
Thought this option, Travis at nupic repo will compile the static
libraries and put them on nupic/build/releasefolder.

The output of this library is a static library called nupic.core (I linked with HtmTest, TesteEverything, and all is ok.. :-) ).

This PR replaces this:
#33

fixes #4

David Ragazzi added 5 commits March 26, 2014 19:48
All source files including tests were moved to "/src" folder. This is
the first step for "nupic.core" be build from "nupic".
Only external API and headers used by "nupic.core" were moved. Binaries
like "swig" remains in "nupic".
-Removed Python stuff;
-Removed unused code;
@rhyolight
Copy link
Member

Alright! I'm going to pull and test this now.

@subutai
Copy link
Member

subutai commented Mar 28, 2014

@Davidragazzi This is great and a big step forward! Hopefully we'll be able to test, review and merge soon. Someone should go through the details of what you did as well and see if we can catch any non-obvious issues.

Updated gitignore to ignore test hpps.
@rhyolight
Copy link
Member

@Davidragazzi I updated the README with build instructions: david-ragazzi#1.

It all build locally for me, but I haven't tried it with nupic yet. I'll try it over the weekend. Please @subutai or @scottpurdy, you guys know more about C++ projects than me. If you get time try this out with nupic. I can't wait to get this integrated! 👯

@david-ragazzi
Copy link
Contributor Author

It all build locally for me, but I haven't tried it with nupic yet. I'll try it over the weekend.

To test locally nupic:

(Dont forget this will change your environment variables, i.e. $NUPIC and $NTA will be pointed to my fork directories.. Be carefull when test in machines that already use nupic for several applications such as Grok)

@david-ragazzi
Copy link
Contributor Author

@Davidragazzi This is great and a big step forward! Hopefully we'll be able to test, review and merge soon. Someone should go through the details of what you did as well and see if we can catch any non-obvious issues.

Thanks @subutai.

Guys, note that now nupic.core is trully stand-alone!! Furthermore, I pulled Windows external static libraries (libapr, libz, etc) in order to someone go ahead to port it to Windows (I believe this job is much easier now.. :-) ).

Also note in CMake file that we simply need specify the source folder for a subproject, not every source file within it.. I.e. CMake transverses the folder and add all the source files found and group them using subfolders hierarchy.. This leaves the project well organized and avoid the creating of additional static libraries to be linked (which leaves the build faster too).

@subutai
Copy link
Member

subutai commented Mar 28, 2014

Furthermore, I pulled Windows external static libraries (libapr, libz, etc) in order to someone go ahead to port it to Windows (I believe this job is much easier now.. :-) ).

Wow - didn't realize that! Cool!

@david-ragazzi
Copy link
Contributor Author

Hi guys,

Have someone reviewing this PR and this http://github.com/numenta/nupic/pull/751?

Please, give attention for them as new PRs are coming and this will bring rework.. :-(

@rhyolight
Copy link
Member

Working on it...

@rhyolight
Copy link
Member

I don't see a problem with this, but @subutai might. Problem is that he is out of the office with no internet until Monday. Let me think about this today and talk with @scottpurdy first. I will get back with another comment by end of day.

Thank you both for your work! And @utensil it's nice to see another person working on these issues! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Establish independent build process
4 participants