-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Independent Build Process #47
Conversation
All source files including tests were moved to "/src" folder. This is the first step for "nupic.core" be build from "nupic".
Only external API and headers used by "nupic.core" were moved. Binaries like "swig" remains in "nupic".
-Removed Python stuff; -Removed unused code;
Alright! I'm going to pull and test this now. |
@Davidragazzi This is great and a big step forward! Hopefully we'll be able to test, review and merge soon. Someone should go through the details of what you did as well and see if we can catch any non-obvious issues. |
Updated gitignore to ignore test hpps.
@Davidragazzi I updated the README with build instructions: david-ragazzi#1. It all build locally for me, but I haven't tried it with |
To test locally
(Dont forget this will change your environment variables, i.e. $NUPIC and $NTA will be pointed to my fork directories.. Be carefull when test in machines that already use nupic for several applications such as Grok) |
Thanks @subutai. Guys, note that now Also note in CMake file that we simply need specify the source folder for a subproject, not every source file within it.. I.e. CMake transverses the folder and add all the source files found and group them using subfolders hierarchy.. This leaves the project well organized and avoid the creating of additional static libraries to be linked (which leaves the build faster too). |
Wow - didn't realize that! Cool! |
Hi guys, Have someone reviewing this PR and this http://github.com/numenta/nupic/pull/751? Please, give attention for them as new PRs are coming and this will bring rework.. :-( |
Working on it... |
I don't see a problem with this, but @subutai might. Problem is that he is out of the office with no internet until Monday. Let me think about this today and talk with @scottpurdy first. I will get back with another comment by end of day. Thank you both for your work! And @utensil it's nice to see another person working on these issues! 😀 |
This commit includes the compilation of the dynamic/static libraries
that compose
nupic.core
. They are generated by default onnupic.core/build/release
folder, however any user could change itsdestination using
cmake -DPROJECT_BUILD_RELEASE_DIR:STRING=…
orcmake -DPROJECT_BUILD_TEMP_DIR:STRING=…
command line.Thought this option, Travis at
nupic
repo will compile the staticlibraries and put them on
nupic/build/release
folder.The output of this library is a static library called nupic.core (I linked with HtmTest, TesteEverything, and all is ok.. :-) ).
This PR replaces this:
#33
fixes #4