Improve UX with better wording #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daproclaima
changed the base branch from
main
to
feature/a11y-keyboard-navigation
daproclaima
force-pushed
the
feature/clearer-ux
branch
from
2c43820
to
6d30f8d
Compare
daproclaima
requested review from
lebaudantoine
and removed request for
lebaudantoine
daproclaima
force-pushed
the
feature/a11y-keyboard-navigation
branch
from
137f006
to
ef4223f
Compare
daproclaima
force-pushed
the
feature/clearer-ux
branch
from
6d30f8d
to
8ac7f69
Compare
daproclaima
force-pushed
the
feature/clearer-ux
branch
from
e68091c
to
549dab4
Compare
daproclaima
force-pushed
the
feature/a11y-keyboard-navigation
branch
13 times, most recently
from
abdfc75
to
f1d46b9
Compare
daproclaima
force-pushed
the
feature/clearer-ux
branch
from
549dab4
to
a00a2d6
Compare
daproclaima
force-pushed
the
feature/clearer-ux
branch
from
a00a2d6
to
0ea45d5
Compare
daproclaima
force-pushed
the
feature/clearer-ux
branch
5 times, most recently
from
ef4ec6e
to
2f79590
Compare
AntoLC
reviewed
Aug 6, 2024
src/frontend/apps/desk/src/features/mail-domains/components/panel/PanelActions.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/desk/src/features/teams/team-management/components/CardCreateTeam.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/desk/src/features/teams/team-management/components/ModalRemoveTeam.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/desk/src/features/teams/team-management/components/TeamInfo.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/desk/src/features/teams/teams-panel/components/PanelActions.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/desk/src/features/teams/teams-panel/components/PanelActions.tsx
Outdated
Show resolved
Hide resolved
daproclaima
force-pushed
the
feature/clearer-ux
branch
5 times, most recently
from
3c5d4d3
to
c83c85a
Compare
daproclaima
force-pushed
the
feature/clearer-ux
branch
7 times, most recently
from
a4d7e03
to
04569a8
Compare
AntoLC
approved these changes
Aug 8, 2024
| @@ -107,7 +107,7 @@ export const MemberGrid = ({ team, currentRole }: MemberGridProps) => { | |||
| {currentRole !== Role.MEMBER && ( | |||
| <Box $margin={{ all: 'big', bottom: 'small' }} $align="flex-end"> | |||
| <Button | |||
| aria-label={t('Add members to the team')} | |||
| aria-label={t('Add a member to the team')} | |||
There was a problem hiding this comment.
The select to add member is a multi select, you can add more than one members.
daproclaima
force-pushed
the
feature/clearer-ux
branch
from
04569a8
to
b7e376c
Compare
- change message showed in mailbox list when none exist - change CTA button text for group management modals - fix 404 page title - update translations - update related e2e tests
- add aria-hidden and empty alt attributes for screen readers to ignore decorative svg and images. - remove icon from input field used to name a group - update translations - update related e2e and components tests
daproclaima
force-pushed
the
feature/clearer-ux
branch
from
b7e376c
to
444f3e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve UX wording and screen reader navigation
Proposal
alt=""andaria-hidden="true"to decorative images and iconsmotivation
Screen readers should ignore decorative images. However, if no alt is provided, the image source URL will be read out loud. To have an image ignored by screen readers, it takes setting an
alt=""to it.For the SVG icons to be ignored by screen readers, they need to take an
aria-hidden="true". However, even browser testing tools like Playwright will ignore them, even though they possess anaria-label="description".aria-labelattributes can hence be removed. To assert their visibility, it takes using visual testing tools such as chromatic.Closes #276, closes #295, closes #296, closes #303, closes #304