Add nupm test
#19
Merged
Add nupm test
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `nupm` by itself will ask to create NUPM_HOME directory, if it does not exist. Also ensures $env.NUPM_HOME exists. The `dirs` module contains utilities and constants related to directories used in nupm.
This allows for other potential flags, such as --git, and running without any flags to install from a package repository.
These are not need for installation, just for publishing.
* Changes module package to install the module, not the whole git repository. * Modules are installed under $env.NUPM_HOME/modules and scripts under $env.NUPM_HOME/scripts. * Adds --force flag to force overwrite * If there is no 'scripts' field in package.nuon in a script package, nupm attempts to install <package_name>.nu.
This allows the build script to know information about itself.
Useful if the build script writes or downloads files, for example.
This also makes it simpler but removes filename information where the test is.
amtoine
reviewed
Oct 3, 2023
Merged
amtoine
added a commit
to amtoine/nushell-nupm
that referenced
this pull request
Oct 4, 2023
this should bring all the new `throw-error` calls from nushell#19.
This was referenced Oct 12, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple test runner to
nupm.nupm testrequires atestsdirectory module—all exported commands from the module are treated as tests to run. It is possible to filter tests by name. The--show-stdoutflag is useful for debugging.Example tests are added for
nupm install. As a consequence, a few bugs innupm installwere discovered and fixed as well.The three tests included in this PR run ~5.7x faster with
nupm testthan usingstd testing run-tests(~127 ms vs. ~735 ms).