Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2)!: new major version #909

Closed
wants to merge 56 commits into from
Closed

feat(v2)!: new major version #909

wants to merge 56 commits into from

Conversation

bdrtsky
Copy link
Contributor

@bdrtsky bdrtsky commented May 15, 2023

Related PRs:

This PR uses beta versions:

  • @nuxt-themes/typography@1.0.0-beta.1
  • @nuxt-themes/tokens@2.0.0-beta.2
  • @nuxt-themes/elements@1.0.0-beta.1

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docus ✅ Ready (Inspect) Visit Preview Jun 6, 2023 4:21pm

@bdrtsky
Copy link
Contributor Author

bdrtsky commented Jun 12, 2023

BREAKING:

  • useMenu renamed to useBodyLock, moved to Elements

@Barbapapazes
Copy link
Contributor

Barbapapazes commented Jun 23, 2023

Hello, I'm currently updating my documentation to be ready for the release, aneoconsulting/armonik-docs-theme#44.

But I found that there is a missing margin on y for the alert.

After:
image

Before:
image

There is the same issue between a list and an alert.

@bdrtsky
Copy link
Contributor Author

bdrtsky commented Jul 3, 2023

@Barbapapazes this happens because you mix Prose components with Elements. Elements doesn't have any positioning styles, unlike Prose. I don't have a nice solution for you currently (until Pinceau fully support local css vars through props), but you can do that for now:

::alert{style="margin-bottom: var(--typography-verticalMargin-base)"}
alert 1
::

::alert{style="margin-bottom: var(--typography-verticalMargin-base)"}
alert 2
::

@Barbapapazes
Copy link
Contributor

@Barbapapazes this happens because you mix Prose components with Elements. Elements doesn't have any positioning styles, unlike Prose. I don't have a nice solution for you currently (until Pinceau fully support local css vars through props), but you can do that for now:

::alert{style="margin-bottom: var(--typography-verticalMargin-base)"}
alert 1
::

::alert{style="margin-bottom: var(--typography-verticalMargin-base)"}
alert 2
::

Thanks for this tip. Could not be the responsibility for Docus to handle this case?

@atinux atinux closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants