Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: release v1 #56

Merged
merged 10 commits into from
Jun 19, 2023
Merged

feat!: release v1 #56

merged 10 commits into from
Jun 19, 2023

Conversation

bdrtsky
Copy link
Contributor

@bdrtsky bdrtsky commented Apr 13, 2023

🚧

@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
typography ✅ Ready (Inspect) Visit Preview Jun 19, 2023 2:22pm

@bdrtsky bdrtsky changed the title fix: remove global tokens to prevent overwrite fix: remove global tokens to prevent overwrite (WIP) Apr 16, 2023
@bdrtsky bdrtsky changed the title fix: remove global tokens to prevent overwrite (WIP) prepare for Docus v2 (WIP) Apr 30, 2023
@Tahul Tahul changed the title prepare for Docus v2 (WIP) feat!: prepare for Docus v2 May 17, 2023
Copy link
Contributor

@Tahul Tahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Aside from the prefixing on component classes I think this is good.

Breaking changes:

  • Typography tokens are now standalone, the do not rely on color or font from the root tokens definition.

@@ -1,5 +1,5 @@
<template>
<code>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about prefixing these classes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefix like what? prose- isn't a prefix?

@Tahul Tahul changed the title feat!: prepare for Docus v2 feat!: release v1 May 25, 2023
@Tahul
Copy link
Contributor

Tahul commented May 25, 2023

Renamed this release v1 as I think that is great opportunity for it.

Releasing it as @beta tag and pre-release for usage in dependent PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants