fix: use compound sort #238

benjamincanac · 2020-07-08T17:33:07Z

Use compoundsort instead of simplesort to handle sorting on multiple fields.

Types of changes

Bug fix (a non-breaking change which fixes an issue)
New feature (a non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

codecov-commenter · 2020-07-08T17:36:04Z

Codecov Report

❗ No coverage uploaded for pull request base (dev@a6f6efa). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev     #238   +/-   ##
======================================
  Coverage       ?   89.42%           
======================================
  Files          ?       15           
  Lines          ?      539           
  Branches       ?      111           
======================================
  Hits           ?      482           
  Misses         ?       50           
  Partials       ?        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f6efa...e9ed0a4. Read the comment docs.

atinux

Looking good, would be nice to have a simple test to cover this

* fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts

* docs: update github link to dev branch * Properly handle anchor tags without href fields (#230) * chore(deps): update dependency @nuxt/static to ^0.0.12 (#234) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update devdependency sass-loader to ^9.0.2 (#235) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: use compound sort (#238) * fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts * chore(deps): update dependency @nuxt/static to v1 (#242) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore: add content:ready hook (#243) * translate configuration.md into japanese * add playground.md in ja * add integrations.md in ja * add examples.md in ja * edit fetching.md * translate wriging.md in ja * update theme.md front matter in ja * translate advanced.md in ja * fix a bit * edit front matter * add translation Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: Philip E Blair <peblairman@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com>

* fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts

* docs: update github link to dev branch * Properly handle anchor tags without href fields (#230) * chore(deps): update dependency @nuxt/static to ^0.0.12 (#234) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update devdependency sass-loader to ^9.0.2 (#235) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: use compound sort (#238) * fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts * chore(deps): update dependency @nuxt/static to v1 (#242) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore: add content:ready hook (#243) * translate configuration.md into japanese * add playground.md in ja * add integrations.md in ja * add examples.md in ja * edit fetching.md * translate wriging.md in ja * update theme.md front matter in ja * translate advanced.md in ja * fix a bit * edit front matter * add translation Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: Philip E Blair <peblairman@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com>

* docs: update github link to dev branch * Properly handle anchor tags without href fields (#230) * chore(deps): update dependency @nuxt/static to ^0.0.12 (#234) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update devdependency sass-loader to ^9.0.2 (#235) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: use compound sort (#238) * fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts * chore(deps): update dependency @nuxt/static to v1 (#242) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore: add content:ready hook (#243) * docs: Update Japanese translate (#245) * docs: update github link to dev branch * Properly handle anchor tags without href fields (#230) * chore(deps): update dependency @nuxt/static to ^0.0.12 (#234) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update devdependency sass-loader to ^9.0.2 (#235) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: use compound sort (#238) * fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts * chore(deps): update dependency @nuxt/static to v1 (#242) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore: add content:ready hook (#243) * translate configuration.md into japanese * add playground.md in ja * add integrations.md in ja * add examples.md in ja * edit fetching.md * translate wriging.md in ja * update theme.md front matter in ja * translate advanced.md in ja * fix a bit * edit front matter * add translation Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: Philip E Blair <peblairman@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> * add user defined parsers * fix empty options * add to default config * add docs * Update nuxt.config.js * Create custom.custom * Update nuxt.config.js * Update index.md * Update configuration.md * Update nuxt.config.js * Update utils.js * Update database.js * test: add options with extend parser Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: Philip E Blair <peblairman@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: 森優太 mori <59682979+uta-mori@users.noreply.github.com>

* fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts

* docs: update github link to dev branch * Properly handle anchor tags without href fields (#230) * chore(deps): update dependency @nuxt/static to ^0.0.12 (#234) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update devdependency sass-loader to ^9.0.2 (#235) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: use compound sort (#238) * fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts * chore(deps): update dependency @nuxt/static to v1 (#242) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore: add content:ready hook (#243) * translate configuration.md into japanese * add playground.md in ja * add integrations.md in ja * add examples.md in ja * edit fetching.md * translate wriging.md in ja * update theme.md front matter in ja * translate advanced.md in ja * fix a bit * edit front matter * add translation Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: Philip E Blair <peblairman@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com>

* docs: update github link to dev branch * Properly handle anchor tags without href fields (#230) * chore(deps): update dependency @nuxt/static to ^0.0.12 (#234) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update devdependency sass-loader to ^9.0.2 (#235) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: use compound sort (#238) * fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts * chore(deps): update dependency @nuxt/static to v1 (#242) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore: add content:ready hook (#243) * docs: Update Japanese translate (#245) * docs: update github link to dev branch * Properly handle anchor tags without href fields (#230) * chore(deps): update dependency @nuxt/static to ^0.0.12 (#234) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update devdependency sass-loader to ^9.0.2 (#235) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: use compound sort (#238) * fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts * chore(deps): update dependency @nuxt/static to v1 (#242) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore: add content:ready hook (#243) * translate configuration.md into japanese * add playground.md in ja * add integrations.md in ja * add examples.md in ja * edit fetching.md * translate wriging.md in ja * update theme.md front matter in ja * translate advanced.md in ja * fix a bit * edit front matter * add translation Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: Philip E Blair <peblairman@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> * add user defined parsers * fix empty options * add to default config * add docs * Update nuxt.config.js * Create custom.custom * Update nuxt.config.js * Update index.md * Update configuration.md * Update nuxt.config.js * Update utils.js * Update database.js * test: add options with extend parser Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: Philip E Blair <peblairman@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: 森優太 mori <59682979+uta-mori@users.noreply.github.com>

cloudflare-workers-and-pages · 2023-09-21T18:36:33Z

Deploying with Cloudflare Pages

Latest commit:	`5a48392`
Status:	✅ Deploy successful!
Preview URL:	https://b21d587b.nuxt-content-1il.pages.dev

View logs

fix(lib): use compound sort

508e078

benjamincanac requested a review from atinux July 8, 2020 17:33

benjamincanac changed the title ~~fix(lib): use compound sort~~ fix: use compound sort Jul 8, 2020

atinux approved these changes Jul 8, 2020

View reviewed changes

benjamincanac added 2 commits July 9, 2020 11:12

fix(lib): plugin sends sorts in wrong order

fd63fd4

test: add with multiple sorts

e9ed0a4

benjamincanac merged commit d0ab1d5 into dev Jul 9, 2020

benjamincanac deleted the fix/use-compound-sort branch July 9, 2020 09:39

benjamincanac added a commit that referenced this pull request Jul 10, 2020

fix: use compound sort (#238)

275c4f0

* fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts

benjamincanac mentioned this pull request Jul 17, 2020

fix: order of query execution #267

Closed

6 tasks

dtmzr mentioned this pull request Jul 17, 2020

How to handle search properly - different result observed #95

Closed

benjamincanac added a commit that referenced this pull request Jul 20, 2020

fix: use compound sort (#238)

a0b41b0

* fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts

benjamincanac added a commit that referenced this pull request Jul 27, 2020

fix: use compound sort (#238)

e7647ef

* fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use compound sort #238

fix: use compound sort #238

benjamincanac commented Jul 8, 2020

codecov-commenter commented Jul 8, 2020 •

edited

Loading

atinux left a comment

cloudflare-workers-and-pages bot commented Sep 21, 2023 •

edited

Loading

fix: use compound sort #238

fix: use compound sort #238

Conversation

benjamincanac commented Jul 8, 2020

Types of changes

codecov-commenter commented Jul 8, 2020 • edited Loading

Codecov Report

atinux left a comment

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Sep 21, 2023 • edited Loading

Deploying with Cloudflare Pages

codecov-commenter commented Jul 8, 2020 •

edited

Loading

cloudflare-workers-and-pages bot commented Sep 21, 2023 •

edited

Loading