feat: add user defined parsers #256

mathe42 · 2020-07-12T14:22:52Z

Types of changes

Bug fix (a non-breaking change which fixes an issue)
New feature (a non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Description

Add option to add UserDefined parsers:

{
   content: {
     extendParser: {
        '.myfile': file => parse(file)
     }
   }
}

fixes #104

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes (if not applicable, please state why)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* docs: update github link to dev branch * Properly handle anchor tags without href fields (#230) * chore(deps): update dependency @nuxt/static to ^0.0.12 (#234) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update devdependency sass-loader to ^9.0.2 (#235) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: use compound sort (#238) * fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts * chore(deps): update dependency @nuxt/static to v1 (#242) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore: add content:ready hook (#243) * translate configuration.md into japanese * add playground.md in ja * add integrations.md in ja * add examples.md in ja * edit fetching.md * translate wriging.md in ja * update theme.md front matter in ja * translate advanced.md in ja * fix a bit * edit front matter * add translation Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: Philip E Blair <peblairman@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com>

codecov-commenter · 2020-07-12T14:29:34Z

Codecov Report

❗ No coverage uploaded for pull request base (dev@ab1cc21). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev     #256   +/-   ##
======================================
  Coverage       ?   90.19%           
======================================
  Files          ?       15           
  Lines          ?      551           
  Branches       ?      118           
======================================
  Hits           ?      497           
  Misses         ?       48           
  Partials       ?        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab1cc21...47aceaa. Read the comment docs.

mathe42 · 2020-07-14T10:17:20Z

@benjamincanac added docs. Can you help me with tests?

atinux · 2020-07-15T17:14:25Z

Thank you for the PR, I think we should rename userParser to extendParser instead.

mathe42 · 2020-07-16T06:18:04Z

@atinux Done.

Build fails in macos for no reason (while yarn connection is lost.) A rerun should fix that.

atinux · 2020-07-16T10:00:26Z

Awesome :)

On thing left is to add a test with a custom parser!

mathe42 · 2020-07-16T10:34:01Z

Yes. But I need help with this... Don't know where to start...

atinux · 2020-07-20T11:20:13Z

@benjamincanac can you help him on the tests onboarding?

benjamincanac · 2020-07-20T15:45:57Z

Hey @mathe42, I've just pushed a test in test/options.test.js, I guess this should be enough, what do you think @atinux?

mathe42 · 2020-07-20T16:31:28Z

Looks good to me.

* docs: update github link to dev branch * Properly handle anchor tags without href fields (#230) * chore(deps): update dependency @nuxt/static to ^0.0.12 (#234) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update devdependency sass-loader to ^9.0.2 (#235) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: use compound sort (#238) * fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts * chore(deps): update dependency @nuxt/static to v1 (#242) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore: add content:ready hook (#243) * docs: Update Japanese translate (#245) * docs: update github link to dev branch * Properly handle anchor tags without href fields (#230) * chore(deps): update dependency @nuxt/static to ^0.0.12 (#234) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update devdependency sass-loader to ^9.0.2 (#235) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: use compound sort (#238) * fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts * chore(deps): update dependency @nuxt/static to v1 (#242) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore: add content:ready hook (#243) * translate configuration.md into japanese * add playground.md in ja * add integrations.md in ja * add examples.md in ja * edit fetching.md * translate wriging.md in ja * update theme.md front matter in ja * translate advanced.md in ja * fix a bit * edit front matter * add translation Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: Philip E Blair <peblairman@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> * add user defined parsers * fix empty options * add to default config * add docs * Update nuxt.config.js * Create custom.custom * Update nuxt.config.js * Update index.md * Update configuration.md * Update nuxt.config.js * Update utils.js * Update database.js * test: add options with extend parser Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: Philip E Blair <peblairman@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: 森優太 mori <59682979+uta-mori@users.noreply.github.com>

benjamincanac and others added 9 commits July 10, 2020 15:49

docs: update github link to dev branch

a1a98aa

Properly handle anchor tags without href fields (#230)

25a4f91

chore(deps): update dependency @nuxt/static to ^0.0.12 (#234)

c50e9ac

Co-authored-by: Renovate Bot <bot@renovateapp.com>

chore(deps): update devdependency sass-loader to ^9.0.2 (#235)

41f5f2f

Co-authored-by: Renovate Bot <bot@renovateapp.com>

fix: use compound sort (#238)

275c4f0

* fix(lib): use compound sort * fix(lib): plugin sends sorts in wrong order * test: add with multiple sorts

chore(deps): update dependency @nuxt/static to v1 (#242)

74e2d8f

Co-authored-by: Renovate Bot <bot@renovateapp.com>

chore: add content:ready hook (#243)

4901648

add user defined parsers

4d56117

mathe42 mentioned this pull request Jul 12, 2020

Parser plugin interface #104

Closed

fix empty options

33cb30d

benjamincanac linked an issue Jul 13, 2020 that may be closed by this pull request

Parser plugin interface #104

Closed

mathe42 added 6 commits July 14, 2020 11:47

add to default config

b87f57f

add docs

fd7c6e3

Update nuxt.config.js

42cf9ed

Create custom.custom

9bb9fed

Update nuxt.config.js

29d6de8

Update index.md

d986a3a

mathe42 added 4 commits July 16, 2020 07:33

Update configuration.md

00a9670

Update nuxt.config.js

7937937

Update utils.js

fcf318a

Update database.js

58a40a9

benjamincanac force-pushed the dev branch from 2207472 to cc2110a Compare July 20, 2020 13:06

test: add options with extend parser

02dc5cc

benjamincanac requested a review from atinux July 20, 2020 15:44

Merge branch 'dev' into patch-4

47aceaa

atinux approved these changes Jul 20, 2020

View reviewed changes

benjamincanac merged commit 3a3dc23 into nuxt:dev Jul 21, 2020

cogor mentioned this pull request Jul 22, 2020

docs: Update Russian docs #283

Merged

2 tasks

mathe42 deleted the patch-4 branch August 2, 2020 13:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add user defined parsers #256

feat: add user defined parsers #256

mathe42 commented Jul 12, 2020 •

edited

Loading

codecov-commenter commented Jul 12, 2020 •

edited

Loading

mathe42 commented Jul 14, 2020

atinux commented Jul 15, 2020

mathe42 commented Jul 16, 2020

atinux commented Jul 16, 2020

mathe42 commented Jul 16, 2020

atinux commented Jul 20, 2020

benjamincanac commented Jul 20, 2020

mathe42 commented Jul 20, 2020

feat: add user defined parsers #256

feat: add user defined parsers #256

Conversation

mathe42 commented Jul 12, 2020 • edited Loading

Types of changes

Description

Checklist:

codecov-commenter commented Jul 12, 2020 • edited Loading

Codecov Report

mathe42 commented Jul 14, 2020

atinux commented Jul 15, 2020

mathe42 commented Jul 16, 2020

atinux commented Jul 16, 2020

mathe42 commented Jul 16, 2020

atinux commented Jul 20, 2020

benjamincanac commented Jul 20, 2020

mathe42 commented Jul 20, 2020

mathe42 commented Jul 12, 2020 •

edited

Loading

codecov-commenter commented Jul 12, 2020 •

edited

Loading