-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resolve rootDir #107
Conversation
For apps it might be better to set If the app is at testDir: Seems perfect for app testing or I missed something? If I get it right Another thing – how do we know if an app or a module is under test? It might be I found a solution. Playing with working prototype right now. Will send in a PR in few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Value of
rootDir
, can be determined by searching in an array of[options.rootDir, resolve(options.testDir, options.fixture), process.cwd()]
- We have a match if dir exists and dir/pages or dir/nuxt.config exists
- If non of array items do match, we should throw an error asking to explicitly set
options.rootDir
pointing to a valid nuxt app
What if Might work, of course. But in some case it will fail. Perhaps it would be helpful to |
Resolves #346, #279