perf: if defined, use rootDir
#125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
May 17, 2021
| configFile: options.configFile, | ||
| configOverrides: options.config | ||
| }) | ||
|
|
||
| if (!options.config.rootDir) { | ||
| options.config.rootDir = options.rootDir |
There was a problem hiding this comment.
config.rootDir is passed to nuxt (core) config. options is for test-utils context.
| @@ -38,22 +37,18 @@ const resolveRootDir = () => { | |||
| export async function loadFixture () { | |||
| const { options } = getContext() | |||
|
|
|||
| options.rootDir = resolveRootDir() | |||
| const rootDir = options.rootDir || resolveRootDir() | |||
There was a problem hiding this comment.
We still should warn users if rootDir is not a valid nuxt app. What's the point of this change?
|
Apologies this was messy PR. Found better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
rootDiris defined, we can simply use that value.(Also it seems like after #107 was merged, line 51 is unreachable.)