-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): add document formatting and code folding providers #41
feat(*): add document formatting and code folding providers #41
Conversation
This PR depends on nuxtlabs/monarch-mdc#12 to export a cjs build in order to consume the formatter from a single source of truth.
The formatter here also only supports spaces at this time. Should we detect tabs and disable (or something), or what's the preferred behavior? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🔥
@farnabaz I forgot to add anything in the README from this 🤦🏼 Also, do you know what it takes to trigger a release for the VS Code extension? |
No worries, we can add it before release, happy to open a PR? :) I'll release a new version this evening |
Any idea when the release will ship? |
There is an issue with built version, folding seems not working. I'll release after fixing it |
Add MDC language format document provider and code folding provider.
Important
This PR requires publishing the changes in nuxtlabs/monarch-mdc#12 and updating this PR to pull in the latest version of
@nuxtlabs/monarch-mdc
I'm utilizing the exported
formatter
andgetDocumentFoldingRanges
functions from the@nuxtlabs/monarch-mdc
package in this PR in order to source the MDC formatting and folding logic from a single source of truth rather than replicating the code here since it's isomorphic.