Add support for a CPU-only Mode #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
added
breaking
Closed
…ncurrent byte-code execution, there is still a chance of context switching inside of the import_morpheus___lib__cudf_helpers
…pe loosely based on a method of the same name from dask-sql
…avid-cpu-only-mode-1846
…as these come at a cost
… based on the use_cudf marker
|
/ok to test |
|
/ok to test |
mdemoret-nv
approved these changes
Oct 18, 2024
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Works-around the issue where CPU-only mode requires using the Python impl of `MessageMeta` a pandas DF, however the `LLMEngineStage` is implemented in C++ and only compatible with the C++ impl of `MessageMeta` with a cudf DF. * Stores the Python impl of `MessageMeta` within the `ControlMessage` metadata which is able to store a Python object as-is. * Updates the Simple Agents & Completion pipelines to optionally execute in CPU-only mode when the `--use_cpu_only` flag is given Requires PR #1851 to be merged first ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1906
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Documents writing a stage that supports CPU execution mode * Updates `docs/source/developer_guide/contributing.md` cleaning up build and troubleshooting sections. Requires PRs #1851 & #1906 to be merged first Closes [#1737](#1737) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1924
rapids-bot bot
pushed a commit
to nv-morpheus/morpheus-visualizations
that referenced
this pull request
Oct 21, 2024
* Requires nv-morpheus/Morpheus#1851 to be merged first Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Michael Demoret (https://github.com/mdemoret-nv) URL: #42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
morpheus.config.ExecutionModewith membersGPU&CPUalong with a newmorpheus.config.Config.execution_modeattribute.Config.execution_modewill always default toGPUsupported_execution_modestoStageBasewhich returnsExecutionMode.GPUby default. This ensures that building a pipeline with a stage not matching the execution mode will raise a reasonable error to the user.CpuOnlyMixinandGpuAndCpuMixinmixins to automate overriding this, and makes it easier for users to determine which execution modes a given stage supports at a glance.cudfor any other GPU based package which will fail on import at the top-level of a module. This is important for stage, message and modules which are automatically imported by the morpheus CLI tool.morpheus.utils.type_utils(ex:get_df_pkg,is_cudf_type) to help avoid importing cudf directlyConfig.freezemethod which will make a config object immutable. This will be called the first time a config object is used to construct a pipeline or stage object. Prevents the possibility of config parameters from being changed in the middle of pipeline construction.CudfHelper::loadis no longer called automatically on import, instead it is called manually on pipeline build when execution mode is GPU.ControlMessageCPU_ONLYenvironment variable is defineddocker/run_container_dev.shwill launch the container using theruncruntime.gpu_and_cpu_modetest marker to explicitly indicate a test intended to be parameterized over execution modes.ControlMessageAppShieldSourceStagenow emitsControlMessages,AppShieldMessageMetais now deprecatedAutoencoderSourceStageand thusAzureSourceStage,CloudTrailSourceStage, andDuoSourceStagenow emitControlMessage,UserMessageMetais now deprecated.DFPMessageMeta, pipeline now executes in C++ mode.docker/run_container_dev.sh&docker/run_container_release.shintodocker/run_container.shTensorMemory.set_tensor([BUG]: Python impl ofTensorMemory.set_tensorreshapes incoming tensors #1955)Closes #1646
Closes #1846
Closes #1852
Closes #1955
By Submitting this PR I confirm: