Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LLM pipelines in CPU-only mode #1906

Merged
merged 347 commits into from
Oct 18, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Sep 23, 2024

Description

  • Works-around the issue where CPU-only mode requires using the Python impl of MessageMeta a pandas DF, however the LLMEngineStage is implemented in C++ and only compatible with the C++ impl of MessageMeta with a cudf DF.
  • Stores the Python impl of MessageMeta within the ControlMessage metadata which is able to store a Python object as-is.
  • Updates the Simple Agents & Completion pipelines to optionally execute in CPU-only mode when the --use_cpu_only flag is given

Requires PR #1851 to be merged first

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

…is that now that Python mode is synonymous with CPU mode, execution in CPU mode will now be considered a special case and not the general case
… this doesn't appear to be used anymore and we're changing the definition of C++ & Python mode
@dagardner-nv
Copy link
Contributor Author

/ok to test

@dagardner-nv
Copy link
Contributor Author

/ok to test

@dagardner-nv
Copy link
Contributor Author

/ok to test

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont love it but I dont know any other way right now.

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 85d5ad4 into nv-morpheus:branch-24.10 Oct 18, 2024
12 checks passed
rapids-bot bot pushed a commit that referenced this pull request Oct 18, 2024
* Documents writing a stage that supports CPU execution mode
* Updates `docs/source/developer_guide/contributing.md` cleaning up build and troubleshooting sections. 

Requires PRs #1851 & #1906 to be merged first

Closes [#1737](#1737)

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement to existing functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants