beta exchange #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixup of #16425 Discussed here: groups.io/g/nvda-translations/message/3819 Summary of the issue: In 2023.2, the user guide heading numbering for the Arabic translation switched to using Western Arabic numbering. 2024.1 mistakenly switched this back to Eastern Arabic numbering. In #16425, the headers in the table of contents were fixed for Western Arabic, but not in the body. Description of user facing changes Restore Western Arabic numbering style for headings in the body of the document Description of development approach Updated CSS to reflect Western Arabic numbering style i.e. .1.2.3, .1.2.4
Summary of the issue: setuptools has been updated, breaking support with py2exe: py2exe/py2exe#208. When installing packages, pip automatically pulls in the latest build dependences as specified in PEP 518. pip creates a custom temporary build environment to install packages using the latest pip environment. Description of development approach Create a pyproject.toml to specify the build environment we are using. packaging.python.org/en/latest/guides/writing-pyproject-toml Use the flag no-build-isolation when installing requirements.txt. This prevent pip from using the custom build environment and automatically pulling the latest setuptools when installing packages. As such, we need to manually install the desired version of setuptools, and manually install pip's dependency wheel. stackoverflow.com/questions/62889093/what-does-no-build-isolation-do
…#16589) Fixes #16318 Summary of the issue: Recently the poedit appModule was rewritten to support poedit 3.4. However, scripts for reading translation nodes, comments and old source text did not function for languages that had no plurals (Chinese) or 2 or more plurals (Polish). It did however function for languages with exactly one plural (such as French). As the controlIDs for windows in poedit are not static, but do stay relative to each other, the appModule originally used offsets from the main dataView control. This worked okay for the translation warning, but did not work for controls in the sidebar in all cases, as it seems that there are extra controlIDs consumed for some hidden windows between the main splitter and the sidebar, depending on how many plurals a language has. E.g. In French, the controlID offset for the Sidebar (relative to the Dataview control) is 29. In Chinese it is 27, and in Plish it is 33. I think it might be roughly two offsets per plural. Description of user facing changes Poedit scripts such as Report translation notes (control+shift+a), Report comments (control+shift+c) and Report old source text (control+shift+o) now function no matter how many plurals a language has. Description of development approach Control ID offsets for controls in the sidebar (such as translation notes, old source text, and comments) are now relative to the sidebar itself, rather than the Dataview control. The sidebar window is located by first finding the main splitter window (using a controlID relative to the dataview control) and then finding the next visible sibling window from there. To aide in refactoring, support for controlID offsets in the Pro version are now handled by simply minusing 5 from the given controlID offset, as all the offsets in the pro version differed by 5. Testing strategy:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.