Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document usage of review by page scripts in Windows Terminal #14025

Closed

Conversation

codeofdusk
Copy link
Contributor

@codeofdusk codeofdusk commented Aug 17, 2022

Link to issue number:

Follow-up of #14021.

Summary of the issue:

New "review by page" scripts were added to NVDA, but their utility in Windows Terminal is not immediately apparent.

Description of how this pull request fixes the issue:

Update documentation and what's new.

Testing strategy:

N/A (no code changes).

Known issues with pull request:

I imagine that these commands will also work in an upcoming (23xx) version of Windows Console (conhost), but with the switch to wt by default in Windows, this probably isn't worth noting.

Change log entries:

See PR

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@codeofdusk
Copy link
Contributor Author

This PR should be ready for 2022.4 by the end of the week, once I know which wt version will have the feature.

@codeofdusk codeofdusk force-pushed the document-wt-page-review branch from 47e6fcf to 4dbb187 Compare October 7, 2022 05:00
@codeofdusk codeofdusk changed the base branch from master to branchFor2022.4 October 7, 2022 05:34
@codeofdusk codeofdusk marked this pull request as ready for review October 7, 2022 05:34
@codeofdusk codeofdusk requested review from a team as code owners October 7, 2022 05:35
@codeofdusk codeofdusk requested review from Qchristensen and seanbudd and removed request for a team October 7, 2022 05:35
@@ -1280,6 +1280,9 @@ The following built-in Windows Console keyboard shortcuts may be useful when [re
| Scroll down | control+downArrow | Scrolls the console window down, so later text can be read. |
| Scroll to start | control+home | Scrolls the console window to the beginning of the buffer. |
| Scroll to end | control+end | Scrolls the console window to the end of the buffer. |

When using Windows Terminal version 1.18 and later, you may use NVDA's Move to previous page in review/Move to next page in review commands to scroll visible screens of output.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to the relevant section of the user guide, and change the wording to improve readability?

Suggested change
When using Windows Terminal version 1.18 and later, you may use NVDA's Move to previous page in review/Move to next page in review commands to scroll visible screens of output.
When using Windows Terminal version 1.18 and later, the gestures ["Move to previous page in review" and "Move to next page in review" commands <add link to section of user guides>] can be used to scroll visible screens of output.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has not been addressed

@seanbudd
Copy link
Member

seanbudd commented Oct 9, 2022

Has 1.18 landed with this change in it?

@seanbudd seanbudd deleted the branch nvaccess:master October 10, 2022 05:09
@seanbudd seanbudd closed this Oct 10, 2022
@codeofdusk
Copy link
Contributor Author

Why was this PR closed?

Has 1.18 landed with this change in it?

It hasn't yet landed, but 1.18 will include the terminal-side changes.

@seanbudd
Copy link
Member

seanbudd commented Oct 10, 2022

It hasn't yet landed, but 1.18 will include the terminal-side changes.

Is there a public reference for this?
We tend not to document unreleased features.

Why was this PR closed?

This was auto closed because the target branch was merged (which is weird, normally it would re-target beta).

@seanbudd
Copy link
Member

it's weirdly not letting me re-open or re-target this PR. When will 1.18 land? I don't think this will make 2022.4 unless 1.18 will land in the next month.

@codeofdusk
Copy link
Contributor Author

Once a public ref lands, might that help you?

@seanbudd seanbudd reopened this Oct 10, 2022
@seanbudd seanbudd changed the base branch from branchFor2022.4 to beta October 10, 2022 05:27
@seanbudd
Copy link
Member

Yes that would help

@carlos-zamora
Copy link

Hi @seanbudd,

Hope this helps: microsoft/terminal#14179 (comment)

I've been working on it for some time now. It's not a difficult change, I've just been caught up by some random other work that comes out of nowhere. Hope this serves as a good enough commitment. 😊

@seanbudd seanbudd changed the base branch from beta to master December 27, 2022 23:01
@@ -12,6 +12,7 @@ What's New in NVDA
- Laptop: ``NVDA+ctrl+shift+.``.
-
- Introduced new commands to move the review cursor by page where supported by the application. (#14021)
- These are especially useful for moving across screens of text, such as paginated output, in Windows Terminal version 1.18 and later.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think In-Process may be a better way to communicate this.
As this feature has not been introduced on the terminal side yet, and the 2022.4 translation freeze is over, this PR can no longer make 2022.4

@seanbudd seanbudd marked this pull request as draft December 28, 2022 00:01
@seanbudd
Copy link
Member

seanbudd commented Mar 4, 2024

Closing this PR. The work appears to be abandoned by MS

@seanbudd seanbudd closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants