-
-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document usage of review by page scripts in Windows Terminal #14025
Conversation
This PR should be ready for 2022.4 by the end of the week, once I know which wt version will have the feature. |
47e6fcf
to
4dbb187
Compare
@@ -1280,6 +1280,9 @@ The following built-in Windows Console keyboard shortcuts may be useful when [re | |||
| Scroll down | control+downArrow | Scrolls the console window down, so later text can be read. | | |||
| Scroll to start | control+home | Scrolls the console window to the beginning of the buffer. | | |||
| Scroll to end | control+end | Scrolls the console window to the end of the buffer. | | |||
|
|||
When using Windows Terminal version 1.18 and later, you may use NVDA's Move to previous page in review/Move to next page in review commands to scroll visible screens of output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a link to the relevant section of the user guide, and change the wording to improve readability?
When using Windows Terminal version 1.18 and later, you may use NVDA's Move to previous page in review/Move to next page in review commands to scroll visible screens of output. | |
When using Windows Terminal version 1.18 and later, the gestures ["Move to previous page in review" and "Move to next page in review" commands <add link to section of user guides>] can be used to scroll visible screens of output. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has not been addressed
Has 1.18 landed with this change in it? |
Why was this PR closed?
It hasn't yet landed, but 1.18 will include the terminal-side changes. |
Is there a public reference for this?
This was auto closed because the target branch was merged (which is weird, normally it would re-target beta). |
it's weirdly not letting me re-open or re-target this PR. When will 1.18 land? I don't think this will make 2022.4 unless 1.18 will land in the next month. |
Once a public ref lands, might that help you? |
Yes that would help |
Hi @seanbudd, Hope this helps: microsoft/terminal#14179 (comment) I've been working on it for some time now. It's not a difficult change, I've just been caught up by some random other work that comes out of nowhere. Hope this serves as a good enough commitment. 😊 |
@@ -12,6 +12,7 @@ What's New in NVDA | |||
- Laptop: ``NVDA+ctrl+shift+.``. | |||
- | |||
- Introduced new commands to move the review cursor by page where supported by the application. (#14021) | |||
- These are especially useful for moving across screens of text, such as paginated output, in Windows Terminal version 1.18 and later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think In-Process may be a better way to communicate this.
As this feature has not been introduced on the terminal side yet, and the 2022.4 translation freeze is over, this PR can no longer make 2022.4
Closing this PR. The work appears to be abandoned by MS |
Link to issue number:
Follow-up of #14021.
Summary of the issue:
New "review by page" scripts were added to NVDA, but their utility in Windows Terminal is not immediately apparent.
Description of how this pull request fixes the issue:
Update documentation and what's new.
Testing strategy:
N/A (no code changes).
Known issues with pull request:
I imagine that these commands will also work in an upcoming (23xx) version of Windows Console (
conhost
), but with the switch towt
by default in Windows, this probably isn't worth noting.Change log entries:
See PR
Code Review Checklist: