Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document usage of review by page scripts in Windows Terminal #14025

Closed
wants to merge 1 commit into from
Closed

Document usage of review by page scripts in Windows Terminal #14025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ What's New in NVDA
- Laptop: ``NVDA+ctrl+shift+.``.
-
- Introduced new commands to move the review cursor by page where supported by the application. (#14021)
- These are especially useful for moving across screens of text, such as paginated output, in Windows Terminal version 1.18 and later.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think In-Process may be a better way to communicate this.
As this feature has not been introduced on the terminal side yet, and the 2022.4 translation freeze is over, this PR can no longer make 2022.4

- Move to previous page:
- Desktop: ``NVDA+pageUp``.
- Laptop: ``NVDA+shift+pageUp``.
Expand Down
5 changes: 4 additions & 1 deletion user_docs/en/userGuide.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1266,7 +1266,7 @@ When in the table view of added books:
| Context menu | applications | Opens the context menu for the selected book. |
%kc:endInclude

++ Windows Console ++[WinConsole]
++ Windows Console and Terminal ++[WinConsole]
NVDA provides support for the Windows command console used by Command Prompt, PowerShell, and the Windows Subsystem for Linux.
The console window is of fixed size, typically much smaller than the buffer that holds the output.
As new text is written, the content scroll upwards and previous text is no longer visible.
Expand All @@ -1280,6 +1280,9 @@ The following built-in Windows Console keyboard shortcuts may be useful when [re
| Scroll down | control+downArrow | Scrolls the console window down, so later text can be read. |
| Scroll to start | control+home | Scrolls the console window to the beginning of the buffer. |
| Scroll to end | control+end | Scrolls the console window to the end of the buffer. |

When using Windows Terminal version 1.18 and later, you may use NVDA's Move to previous page in review/Move to next page in review commands to scroll visible screens of output.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to the relevant section of the user guide, and change the wording to improve readability?

Suggested change
When using Windows Terminal version 1.18 and later, you may use NVDA's Move to previous page in review/Move to next page in review commands to scroll visible screens of output.
When using Windows Terminal version 1.18 and later, the gestures ["Move to previous page in review" and "Move to next page in review" commands <add link to section of user guides>] can be used to scroll visible screens of output.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has not been addressed

This can be used, for instance, to jump to the top of a currently visible page of paginated output from commands such as ``less``.
%kc:endInclude

+ Configuring NVDA +[ConfiguringNVDA]
Expand Down