Sass bugs fixing #167
Merged
Sass bugs fixing #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jest-preview-library canceled.
|
|
@ntt261298 I think we can solve 2 issues by 2 different PRs, so we can ship it faster. What do you think? |
I just update the description to include only 1 issue. Please help to take a look at the update. Thanks a lot. |
nvh95
reviewed
Jul 1, 2022
| ], | ||
| }) | ||
| .css.toString(); | ||
| } |
There was a problem hiding this comment.
@ntt261298 Can we just throw an error in else block?
|
@ntt261298 I think we should have 2 tests to make sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
scss<1.45.0#164Fixes
\before_(\is automatically added before_when pressing save)\), we might change.envfile in the future and someone will commit the change (Added comment to notice this)Chores
@emotion/reactnoticeable: Currently when hovering over the button, the color is still remaining white, so it's not noticeable => Change text color to blue