-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sass bugs fixing #167
Merged
Merged
Sass bugs fixing #167
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
290508d
feat: Support Sass version <1.45.0
ntt261298 626343d
fix: Make example @emotion/react noticable
ntt261298 d24bb7a
fix: Correct a comment's position
ntt261298 6a4a3a2
feat: Add comment to clarify why we should use sass.renderSync
ntt261298 c62e401
fix: Remove redundant \ character
ntt261298 98e5953
refactor: Throw error in case no compile sass method is available
ntt261298 fae0a61
refactor: Add comment to notice that we don't add \ before .scss
ntt261298 925e10d
chore: prettier ignore .env files
nvh95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
.env | ||
.env.* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,7 +41,7 @@ function App() { | |
font-size: 24px; | ||
border-radius: 4px; | ||
&:hover { | ||
color: white; | ||
color: blue; | ||
} | ||
`} | ||
> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
<!-- Use SASS_PATH causes CRA throw 1 warning, it looks like this is an issue of CRA | ||
Reference: https://github.com/facebook/create-react-app/issues/12329 --> | ||
|
||
SASS_PATH=src/assets/\_scss/loadPathsExample | ||
<!-- Warning: Do not add \ before _scss --> | ||
SASS_PATH=src/assets/_scss/loadPathsExample | ||
NODE_PATH=node_modules/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ntt261298 Can we just throw an error in
else
block?