Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling plenary.scandir is slow #106

Closed
jonashaag opened this issue Jul 20, 2023 · 2 comments · Fixed by #100
Closed

Calling plenary.scandir is slow #106

jonashaag opened this issue Jul 20, 2023 · 2 comments · Fixed by #100

Comments

@jonashaag
Copy link

In the default config, opening frecency is much slower than Telescope's built-in find_files because plenary.scandir is really slow. I think it doesn't use ripgrep/fd.
@delphinus
Copy link
Member

I'm refactoring the whole source in #100, and planning to use vim.fs.dir instead of plenary.scandir not to block Neovim. It seems to work nicely in my env.

@delphinus delphinus mentioned this issue Jul 29, 2023
Merged
15 tasks
delphinus added a commit that referenced this issue Aug 6, 2023
@delphinus
refactor!: use OO & add tests (#100)
1f32091 
* I did an overhall for all codes and added typing by Lua-language-server and tests. It also works on CI.
* Now it searches files on the workspace completely asynchronously. It does not block your text input. (Fix #106)
Make count = 1 when you open a file you've never opened (Fix #107)
@delphinus
Copy link
Member

I merged #100. Now it does not block your input even on a folder containing huge amount of files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: use OO & add tests nvim-telescope/telescope-frecency.nvim
2 participants
@jonashaag @delphinus