-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: use OO & add tests #100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It works almost the same. A few bugs still exist.
This is for a testing purpose.
delphinus
force-pushed
the
feature/oo
branch
3 times, most recently
from
July 28, 2023 08:24
20afb6f
to
35df52d
Compare
In searching workspace
delphinus
force-pushed
the
feature/oo
branch
4 times, most recently
from
July 29, 2023 02:37
47c515f
to
5474f95
Compare
delphinus
force-pushed
the
feature/oo
branch
6 times, most recently
from
August 5, 2023 22:58
73bbf0c
to
42c3e70
Compare
This was referenced Aug 6, 2023
This was referenced Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did an overhall for all codes and am refactoring them with OO-like format and typing by Lua-language-server. I will add unit & integration tests for robustness.
You can try the new version of frecency with settings below. The old version can use with this.I have deleted the old logic in a15766e. You can simply switch this branch to use the new logic.
TODO
.gitignore
inscandir
auto_validate
disable_devicons
:Telescope frecency
:Telescope frecnecy workspace=CWD
, it does not filter the results with workspace.:Telescope frecency
:CWD:
to filter out.:CWD:
and it should show the first look again, but it does not.vim.fs.dir
instead ofplenary.scandir
.async_finder.lua
.count = 0
#107)less priority TODO
frecency:register()
to load at first, but does not need dependencies until:Telescope frecency
starts.