Skip to content

feat(live-filter): add ability to live filter out nodes in the tree #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2022

Conversation

kyazdani42
Copy link
Member

@kyazdani42 kyazdani42 commented Mar 6, 2022

This PR adds the ability to filter out nodes visually in the tree. It is filtering and redrawing while typing, which should provide a good user experience.

it is very much unfinished, there are some caveats.
I'm leaving this PR open until everything is properly finished to let people discuss what would be nice to implement and potential issues that this implementation would introduce.

TODO:

  • fix filtering on grouped nodes
  • allow configuration for prompt
  • documentation

TODO in followup PR:

  • filter opened buffers
  • allow user to pass custom init / deinit / matching functions.
  • filter with automatic depth search

@suessflorian
Copy link

You rock @kyazdani42, keep it up :)

@kyazdani42 kyazdani42 force-pushed the feat/add-live-filtering branch from f825123 to f6e575c Compare March 8, 2022 20:00
@be-ndee
Copy link
Contributor

be-ndee commented Mar 9, 2022

Great feature!

An idea: at the moment it only filters the visible nodes. It would be cool to filter also not visible trees as well.

@kyazdani42 kyazdani42 force-pushed the feat/add-live-filtering branch 11 times, most recently from 3c2b96b to a4a5b10 Compare March 9, 2022 22:52
@kyazdani42
Copy link
Member Author

@be-ndee yep, there are some todos in the "live-filter.lua" file at the top. I think i'm happy with this implementation.
I still have some modules to fix before improving the filtering and searching logic.
The issue with the in depth search would make it very slow. I'm not sure yet what the right solution would be for that scenario.

@kyazdani42 kyazdani42 force-pushed the feat/add-live-filtering branch 4 times, most recently from aa897e9 to f424d8f Compare March 12, 2022 16:11
@kyazdani42 kyazdani42 force-pushed the feat/add-live-filtering branch 2 times, most recently from bbf8c52 to 7b74554 Compare March 18, 2022 11:04
@kyazdani42 kyazdani42 force-pushed the feat/add-live-filtering branch 5 times, most recently from 54664ab to bf8cb2a Compare March 27, 2022 10:22
@kyazdani42 kyazdani42 force-pushed the feat/add-live-filtering branch from bf8cb2a to 5f4b5b7 Compare April 2, 2022 11:16
@kyazdani42 kyazdani42 marked this pull request as ready for review May 14, 2022 09:41
@kyazdani42 kyazdani42 requested a review from alex-courtis May 14, 2022 09:41
@kyazdani42
Copy link
Member Author

@alex-courtis i think this is good enough for a first implementation :) I've worked out all the issues i believe so this should be okay for a first release.
This will need to be extended (see the TODO in followup pr on the PR Comment).

@alex-courtis
Copy link
Member

alex-courtis commented May 15, 2022

Testing Notes, successful cases not mentioned.

Nice to have:

  • action to clear the filter

Limitations:

  • always_show_folders = true hides folders that contain matches unless that folder has already been opened. e.g. find view.lua shows an empty tree until we have manually opened lua/nvim-tree.

Bugs:

  • prefix = "" shows the filter dialogue on the wrong line
    20220515_160119 1606x1024
    20220515_160148 1606x1024

  • Clicking another window whilst inside the filter input results in nvim-tree buffer stuck in insert mode. Not sure there is much we can do about this
    asciicast

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. Let's fix these before merge:

  • action to clear the filter
  • prefix = "" using wrong line

Later:

The input window works. My edge cases are overcritical. Act only if someone complains or finds significant bugs.

Hiding matching files when always_show_folders = true is a problem, but can be addressed in the future. It will need a filesystem search to resolve.

@kyazdani42 kyazdani42 force-pushed the feat/add-live-filtering branch 2 times, most recently from f0aed53 to 4efd92b Compare May 15, 2022 08:38
@kyazdani42 kyazdani42 force-pushed the feat/add-live-filtering branch from 4efd92b to ecca2bc Compare May 15, 2022 08:46
@kyazdani42 kyazdani42 requested a review from alex-courtis May 15, 2022 08:46
@kyazdani42
Copy link
Member Author

@alex-courtis i've managed to fix the empty filter issue, and added a keybinding to clear the filter (i completely forgot to add it 😄)
I'm not sure what you mean by

Hiding matching files when always_show_folders = true is a problem, but can be addressed in the future. It will need a filesystem search to resolve.

always show folders should not change behavior of the filter. It only displays folders even without matches to allow opening folders manually which should show matching files if there are any.

Although the search is mentioned in my comment, i decided to not add it here because i would make the feature more complex, as a first draft, i decided to keep it simple for now. This will be added in a future version, once we find a proper way to do it without bursting the CPU ^^

@gegoune

This comment was marked as outdated.

@kyazdani42
Copy link
Member Author

@gegoune see the comment on PR 😄

@gegoune

This comment was marked as outdated.

@alex-courtis
Copy link
Member

I'm not sure what you mean by

First we use always_show_folders = true and can find view.lua

Then we use always_show_folders = false and cannot find view.lua until after we have opened lua/nvim-tree once.

This isn't a blocker, just a limitation of the filter. We can S for view.lua as it does a filesystem search.

asciicast

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested some cases when searching filtered trees. No surprises.

@kyazdani42 kyazdani42 merged commit 6343813 into master May 17, 2022
@kyazdani42 kyazdani42 deleted the feat/add-live-filtering branch May 17, 2022 08:03
mosheavni pushed a commit to mosheavni/nvim-tree.lua that referenced this pull request May 22, 2022
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

# This is a combination of 13 commits.
# This is the 1st commit message:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#2:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)


# This is the commit message nvim-tree#3:

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

# This is the commit message nvim-tree#4:

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

# This is the commit message nvim-tree#5:

fix(renderer): empty space at end of line

fixes nvim-tree#1253

# This is the commit message nvim-tree#6:

add fish performance tip to README.md
# This is the commit message nvim-tree#7:

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)


# This is the commit message nvim-tree#8:

feat: reload explorer on buf enter (nvim-tree#1265)


# This is the commit message nvim-tree#9:

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

# This is the commit message nvim-tree#10:

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

# This is the commit message nvim-tree#11:

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

# This is the commit message nvim-tree#12:

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)


# This is the commit message nvim-tree#13:

Ignore case when removing default mappings

# This is the commit message nvim-tree#14:

issue#362: File Management popup menu UI. First Iteration.
mosheavni pushed a commit to mosheavni/nvim-tree.lua that referenced this pull request May 22, 2022
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring
mosheavni pushed a commit to mosheavni/nvim-tree.lua that referenced this pull request May 22, 2022
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.
mosheavni pushed a commit to mosheavni/nvim-tree.lua that referenced this pull request May 22, 2022
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md
mosheavni pushed a commit to mosheavni/nvim-tree.lua that referenced this pull request May 22, 2022
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

# This is a combination of 13 commits.
# This is the 1st commit message:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#2:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)


# This is the commit message nvim-tree#3:

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

# This is the commit message nvim-tree#4:

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

# This is the commit message nvim-tree#5:

fix(renderer): empty space at end of line

fixes nvim-tree#1253

# This is the commit message nvim-tree#6:

add fish performance tip to README.md
# This is the commit message nvim-tree#7:

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)


# This is the commit message nvim-tree#8:

feat: reload explorer on buf enter (nvim-tree#1265)


# This is the commit message nvim-tree#9:

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

# This is the commit message nvim-tree#10:

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

# This is the commit message nvim-tree#11:

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

# This is the commit message nvim-tree#12:

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)


# This is the commit message nvim-tree#13:

Ignore case when removing default mappings

# This is the commit message nvim-tree#14:

issue#362: File Management popup menu UI. First Iteration.

# This is the commit message nvim-tree#15:

Workin on menu refactoring

# This is the commit message nvim-tree#17:

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

# This is the commit message nvim-tree#18:

Update README.md

# This is the commit message nvim-tree#19:

updated popup-menu/init.lua

# This is the commit message nvim-tree#20:

Update init.lua
# This is the commit message nvim-tree#21:

Update README.md
mosheavni pushed a commit to mosheavni/nvim-tree.lua that referenced this pull request May 22, 2022
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done
mosheavni pushed a commit to mosheavni/nvim-tree.lua that referenced this pull request May 22, 2022
# This is the 1st commit message:

refactor: use lua api for user commands and autocommands (nvim-tree#1206)

BREAKING: plugin now requires nvim-0.7
# This is the commit message nvim-tree#2:

# This is a combination of 14 commits.tree a88ac1b
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

# This is a combination of 13 commits.
# This is the 1st commit message:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#2:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)


# This is the commit message nvim-tree#3:

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

# This is the commit message nvim-tree#4:

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

# This is the commit message nvim-tree#5:

fix(renderer): empty space at end of line

fixes nvim-tree#1253

# This is the commit message nvim-tree#6:

add fish performance tip to README.md
# This is the commit message nvim-tree#7:

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)


# This is the commit message nvim-tree#8:

feat: reload explorer on buf enter (nvim-tree#1265)


# This is the commit message nvim-tree#9:

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

# This is the commit message nvim-tree#10:

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

# This is the commit message nvim-tree#11:

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

# This is the commit message nvim-tree#12:

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)


# This is the commit message nvim-tree#13:

Ignore case when removing default mappings

# This is the commit message nvim-tree#14:

issue#362: File Management popup menu UI. First Iteration.

# This is the commit message nvim-tree#3:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

# This is the commit message nvim-tree#4:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

# This is the commit message nvim-tree#5:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

# This is the commit message nvim-tree#6:

# This is a combination of 21 commits.
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

# This is a combination of 13 commits.
# This is the 1st commit message:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#2:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)


# This is the commit message nvim-tree#3:

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

# This is the commit message nvim-tree#4:

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

# This is the commit message nvim-tree#5:

fix(renderer): empty space at end of line

fixes nvim-tree#1253

# This is the commit message nvim-tree#6:

add fish performance tip to README.md
# This is the commit message nvim-tree#7:

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)


# This is the commit message nvim-tree#8:

feat: reload explorer on buf enter (nvim-tree#1265)


# This is the commit message nvim-tree#9:

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

# This is the commit message nvim-tree#10:

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

# This is the commit message nvim-tree#11:

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

# This is the commit message nvim-tree#12:

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)


# This is the commit message nvim-tree#13:

Ignore case when removing default mappings

# This is the commit message nvim-tree#14:

issue#362: File Management popup menu UI. First Iteration.

# This is the commit message nvim-tree#15:

Workin on menu refactoring

# This is the commit message nvim-tree#17:

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

# This is the commit message nvim-tree#18:

Update README.md

# This is the commit message nvim-tree#19:

updated popup-menu/init.lua

# This is the commit message nvim-tree#20:

Update init.lua
# This is the commit message nvim-tree#21:

Update README.md
# This is the commit message nvim-tree#7:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done

# This is the commit message nvim-tree#8:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#9:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)
mosheavni pushed a commit to mosheavni/nvim-tree.lua that referenced this pull request May 22, 2022
# This is the 1st commit message:

refactor: use lua api for user commands and autocommands (nvim-tree#1206)

BREAKING: plugin now requires nvim-0.7
# This is the commit message nvim-tree#2:

# This is a combination of 14 commits.tree a88ac1b
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

# This is a combination of 13 commits.
# This is the 1st commit message:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#2:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)


# This is the commit message nvim-tree#3:

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

# This is the commit message nvim-tree#4:

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

# This is the commit message nvim-tree#5:

fix(renderer): empty space at end of line

fixes nvim-tree#1253

# This is the commit message nvim-tree#6:

add fish performance tip to README.md
# This is the commit message nvim-tree#7:

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)


# This is the commit message nvim-tree#8:

feat: reload explorer on buf enter (nvim-tree#1265)


# This is the commit message nvim-tree#9:

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

# This is the commit message nvim-tree#10:

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

# This is the commit message nvim-tree#11:

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

# This is the commit message nvim-tree#12:

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)


# This is the commit message nvim-tree#13:

Ignore case when removing default mappings

# This is the commit message nvim-tree#14:

issue#362: File Management popup menu UI. First Iteration.

# This is the commit message nvim-tree#3:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

# This is the commit message nvim-tree#4:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

# This is the commit message nvim-tree#5:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

# This is the commit message nvim-tree#6:

# This is a combination of 21 commits.
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

# This is a combination of 13 commits.
# This is the 1st commit message:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#2:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)


# This is the commit message nvim-tree#3:

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

# This is the commit message nvim-tree#4:

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

# This is the commit message nvim-tree#5:

fix(renderer): empty space at end of line

fixes nvim-tree#1253

# This is the commit message nvim-tree#6:

add fish performance tip to README.md
# This is the commit message nvim-tree#7:

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)


# This is the commit message nvim-tree#8:

feat: reload explorer on buf enter (nvim-tree#1265)


# This is the commit message nvim-tree#9:

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

# This is the commit message nvim-tree#10:

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

# This is the commit message nvim-tree#11:

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

# This is the commit message nvim-tree#12:

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)


# This is the commit message nvim-tree#13:

Ignore case when removing default mappings

# This is the commit message nvim-tree#14:

issue#362: File Management popup menu UI. First Iteration.

# This is the commit message nvim-tree#15:

Workin on menu refactoring

# This is the commit message nvim-tree#17:

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

# This is the commit message nvim-tree#18:

Update README.md

# This is the commit message nvim-tree#19:

updated popup-menu/init.lua

# This is the commit message nvim-tree#20:

Update init.lua
# This is the commit message nvim-tree#21:

Update README.md
# This is the commit message nvim-tree#7:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done

# This is the commit message nvim-tree#8:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#9:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)


# This is the commit message nvim-tree#10:

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

# This is the commit message nvim-tree#11:

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253
mosheavni pushed a commit to mosheavni/nvim-tree.lua that referenced this pull request May 22, 2022
)

BREAKING: plugin now requires nvim-0.7

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

remove
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants