refactor: use lua api for user commands and autocommands #1206

sarmong · 2022-04-27T15:30:14Z

I am still a bit new to autocommands, so please double-check that everything works

alex-courtis

~~We should update the minimum version of neovim to 0.7~~

~~lua API for :au and :map was not reliable in 0.6~~

Edit: I see that you have already done this!

incorrect

alex-courtis

Great update, thank you

alex-courtis · 2022-04-28T01:19:04Z

We should do a neovim version check when nvim-tree starts.

< 0.7 will result in a warning and nvim-tree does not start.

@kyazdani42 ?

kyazdani42 · 2022-04-28T11:52:43Z

I'd prefer leaving a month to let people update before forcing this on everybody :) Some package managers might not have updated their neovim distribution yet.

sarmong · 2022-04-28T11:59:30Z

I'd prefer leaving a month to let people update before forcing this on everybody :) Some package managers might not have updated their neovim distribution yet.

Treesitter updated a couple days after the 0.7 release. And it is very likely that 90% of nvim-tree users use treesitter as well. So they either already updated everything, or know how hold updates if they don't want to

kyazdani42 · 2022-04-28T17:06:03Z

i guess so. Then, i'll test this properly this weekend and merge it if it's all okay :)

alex-courtis

Tested most changes with 0.7.

Confirmed that it fails with 0.6.

We must add the startup version check before merging this.

lua/nvim-tree.lua

lua/nvim-tree/actions/open-file.lua

lua/nvim-tree.lua

kyazdani42

almost good :) Could you rebase and manage the autocmd for coc diagnostic updates that has been just added ?
Also could you replace all the vim.api to api ? It's declared on top of the file :)

lua/nvim-tree.lua

kyazdani42

LGTM, @alex-courtis can you make a last review ? Then we'll merge.
I think i'll add a new issue for breaking change.

alex-courtis · 2022-05-09T00:38:45Z

lua/nvim-tree.lua

@@ -476,6 +502,11 @@ local function validate_options(conf)
 end

 function M.setup(conf)
+  if vim.fn.has "nvim-0.7" == 0 then


0.6.1 exits early
0.7.0 works normally

lua/nvim-tree/diagnostics.lua

alex-courtis · 2022-05-09T00:46:41Z

lua/nvim-tree.lua

@@ -504,6 +504,7 @@ end
 function M.setup(conf)
  if vim.fn.has "nvim-0.7" == 0 then
    utils.warn "nvim-tree.lua requires Neovim 0.7 or higher"
+    return


This is good.

# This is the 1st commit message: refactor: use lua api for user commands and autocommands (nvim-tree#1206) BREAKING: plugin now requires nvim-0.7 # This is the commit message nvim-tree#2: # This is a combination of 14 commits.tree a88ac1b parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 # This is a combination of 13 commits. # This is the 1st commit message: feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) # This is the commit message nvim-tree#2: feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) # This is the commit message nvim-tree#3: Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 # This is the commit message nvim-tree#4: fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 # This is the commit message nvim-tree#5: fix(renderer): empty space at end of line fixes nvim-tree#1253 # This is the commit message nvim-tree#6: add fish performance tip to README.md # This is the commit message nvim-tree#7: feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) # This is the commit message nvim-tree#8: feat: reload explorer on buf enter (nvim-tree#1265) # This is the commit message nvim-tree#9: chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) # This is the commit message nvim-tree#10: chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 # This is the commit message nvim-tree#11: refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. # This is the commit message nvim-tree#12: feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) # This is the commit message nvim-tree#13: Ignore case when removing default mappings # This is the commit message nvim-tree#14: issue#362: File Management popup menu UI. First Iteration. # This is the commit message nvim-tree#3: parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring # This is the commit message nvim-tree#4: parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. # This is the commit message nvim-tree#5: parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. Update README.md # This is the commit message nvim-tree#6: # This is a combination of 21 commits. parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 # This is a combination of 13 commits. # This is the 1st commit message: feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) # This is the commit message nvim-tree#2: feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) # This is the commit message nvim-tree#3: Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 # This is the commit message nvim-tree#4: fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 # This is the commit message nvim-tree#5: fix(renderer): empty space at end of line fixes nvim-tree#1253 # This is the commit message nvim-tree#6: add fish performance tip to README.md # This is the commit message nvim-tree#7: feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) # This is the commit message nvim-tree#8: feat: reload explorer on buf enter (nvim-tree#1265) # This is the commit message nvim-tree#9: chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) # This is the commit message nvim-tree#10: chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 # This is the commit message nvim-tree#11: refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. # This is the commit message nvim-tree#12: feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) # This is the commit message nvim-tree#13: Ignore case when removing default mappings # This is the commit message nvim-tree#14: issue#362: File Management popup menu UI. First Iteration. # This is the commit message nvim-tree#15: Workin on menu refactoring # This is the commit message nvim-tree#17: Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. # This is the commit message nvim-tree#18: Update README.md # This is the commit message nvim-tree#19: updated popup-menu/init.lua # This is the commit message nvim-tree#20: Update init.lua # This is the commit message nvim-tree#21: Update README.md # This is the commit message nvim-tree#7: parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. Update README.md updated popup-menu/init.lua Update init.lua Update README.md Done parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. Update README.md updated popup-menu/init.lua Update init.lua Update README.md Done # This is the commit message nvim-tree#8: feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) # This is the commit message nvim-tree#9: feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

# This is the 1st commit message: refactor: use lua api for user commands and autocommands (nvim-tree#1206) BREAKING: plugin now requires nvim-0.7 # This is the commit message nvim-tree#2: # This is a combination of 14 commits.tree a88ac1b parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 # This is a combination of 13 commits. # This is the 1st commit message: feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) # This is the commit message nvim-tree#2: feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) # This is the commit message nvim-tree#3: Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 # This is the commit message nvim-tree#4: fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 # This is the commit message nvim-tree#5: fix(renderer): empty space at end of line fixes nvim-tree#1253 # This is the commit message nvim-tree#6: add fish performance tip to README.md # This is the commit message nvim-tree#7: feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) # This is the commit message nvim-tree#8: feat: reload explorer on buf enter (nvim-tree#1265) # This is the commit message nvim-tree#9: chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) # This is the commit message nvim-tree#10: chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 # This is the commit message nvim-tree#11: refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. # This is the commit message nvim-tree#12: feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) # This is the commit message nvim-tree#13: Ignore case when removing default mappings # This is the commit message nvim-tree#14: issue#362: File Management popup menu UI. First Iteration. # This is the commit message nvim-tree#3: parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring # This is the commit message nvim-tree#4: parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. # This is the commit message nvim-tree#5: parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. Update README.md # This is the commit message nvim-tree#6: # This is a combination of 21 commits. parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 # This is a combination of 13 commits. # This is the 1st commit message: feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) # This is the commit message nvim-tree#2: feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) # This is the commit message nvim-tree#3: Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 # This is the commit message nvim-tree#4: fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 # This is the commit message nvim-tree#5: fix(renderer): empty space at end of line fixes nvim-tree#1253 # This is the commit message nvim-tree#6: add fish performance tip to README.md # This is the commit message nvim-tree#7: feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) # This is the commit message nvim-tree#8: feat: reload explorer on buf enter (nvim-tree#1265) # This is the commit message nvim-tree#9: chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) # This is the commit message nvim-tree#10: chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 # This is the commit message nvim-tree#11: refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. # This is the commit message nvim-tree#12: feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) # This is the commit message nvim-tree#13: Ignore case when removing default mappings # This is the commit message nvim-tree#14: issue#362: File Management popup menu UI. First Iteration. # This is the commit message nvim-tree#15: Workin on menu refactoring # This is the commit message nvim-tree#17: Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. # This is the commit message nvim-tree#18: Update README.md # This is the commit message nvim-tree#19: updated popup-menu/init.lua # This is the commit message nvim-tree#20: Update init.lua # This is the commit message nvim-tree#21: Update README.md # This is the commit message nvim-tree#7: parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. Update README.md updated popup-menu/init.lua Update init.lua Update README.md Done parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. Update README.md updated popup-menu/init.lua Update init.lua Update README.md Done # This is the commit message nvim-tree#8: feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) # This is the commit message nvim-tree#9: feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) # This is the commit message nvim-tree#10: Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 # This is the commit message nvim-tree#11: fix(renderer): padding when git icons are after the name fixes nvim-tree#1253

) BREAKING: plugin now requires nvim-0.7 parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. Update README.md parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. Update README.md updated popup-menu/init.lua Update init.lua Update README.md parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. Update README.md updated popup-menu/init.lua Update init.lua Update README.md Done parent 4601444 author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200 committer Moshe Avni <mavni@netapp.com> 1653224067 +0300 feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) Ignore case when removing default mappings issue#362: File Management popup menu UI. First Iteration. Workin on menu refactoring Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test. Update README.md updated popup-menu/init.lua Update init.lua Update README.md Done feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242) feat: extension sorter (nvim-tree#1181) (nvim-tree#1264) Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)" This reverts commit 90d7b8e. fixes nvim-tree#1267 fix(renderer): padding when git icons are after the name fixes nvim-tree#1253 fix(renderer): empty space at end of line fixes nvim-tree#1253 add fish performance tip to README.md feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056) feat: reload explorer on buf enter (nvim-tree#1265) chore(config): auto resize the tree by default when opening a file. config.open_file.auto_resize is now true by default. Breaking change for default configurations. See nvim-tree#1275 (comment) chore: remove custom set local implementation Seems vim.opt_local has been fixed. see neovim/neovim#14670 refactor: simplify opening file in new tab fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was true. This introduces breaking change since we don't do any extra behavior and let the buffer be opened by the tree. The previous behavior was a bit old and i believe this should've been fixed by now. Reference this commit if unexpected behavior appears while opening files in new tabs from nvim-tree. feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276) remove

) BREAKING: plugin now requires nvim-0.7

sarmong marked this pull request as draft April 27, 2022 15:56

sarmong force-pushed the master branch from 66c3640 to 84a47c3 Compare April 27, 2022 17:48

sarmong marked this pull request as ready for review April 27, 2022 17:50

sarmong changed the title ~~refactor: use lua for preview autocommands~~ refactor: use lua api for user commands and autocommands Apr 27, 2022

alex-courtis requested changes Apr 28, 2022

View reviewed changes

alex-courtis previously approved these changes Apr 28, 2022

View reviewed changes

alex-courtis approved these changes Apr 28, 2022

View reviewed changes

alex-courtis self-requested a review April 30, 2022 00:12

alex-courtis requested changes Apr 30, 2022

View reviewed changes

kyazdani42 requested changes Apr 30, 2022

View reviewed changes

lua/nvim-tree.lua Outdated Show resolved Hide resolved

lua/nvim-tree/actions/open-file.lua Outdated Show resolved Hide resolved

sarmong force-pushed the master branch from aeb2391 to dbbc5c8 Compare May 8, 2022 05:27

sarmong requested review from alex-courtis and kyazdani42 May 8, 2022 05:28

alex-courtis requested changes May 8, 2022

View reviewed changes

lua/nvim-tree.lua Outdated Show resolved Hide resolved

kyazdani42 reviewed May 8, 2022

View reviewed changes

lua/nvim-tree.lua Show resolved Hide resolved

sarmong added 10 commits May 8, 2022 13:16

refactor: use lua for preview autocommands

9881081

refactor: use lua for nvim-tree autocmd

be42735

refactor: use lua for file-popup autocmd

d736e90

refactor: use lua api for user commands

d3134f5

docs: update notice for the required nvim version to 0.7

a619465

improvements per review

72312e2

check version

575082a

fix version check

1515ddf

update coc autocommands

ab7d565

use api instead of vim.api

0682b5d

sarmong force-pushed the master branch from 458f6f9 to 0682b5d Compare May 8, 2022 10:24

add return if lower version

d368c7e

sarmong requested review from kyazdani42 and alex-courtis and removed request for alex-courtis May 8, 2022 10:27

kyazdani42 approved these changes May 8, 2022

View reviewed changes

alex-courtis requested changes May 9, 2022

View reviewed changes

fix typo

19598be

sarmong requested a review from alex-courtis May 13, 2022 18:36

alex-courtis approved these changes May 14, 2022

View reviewed changes

kyazdani42 approved these changes May 14, 2022

View reviewed changes

kyazdani42 merged commit 4601444 into nvim-tree:master May 14, 2022

Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022

refactor: use lua api for user commands and autocommands (nvim-tree#1206

9ac1625

) BREAKING: plugin now requires nvim-0.7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor: use lua api for user commands and autocommands #1206

refactor: use lua api for user commands and autocommands #1206

Uh oh!

sarmong commented Apr 27, 2022 •

edited

Loading

Uh oh!

alex-courtis left a comment •

edited

Loading

Uh oh!

alex-courtis left a comment

Uh oh!

alex-courtis commented Apr 28, 2022

Uh oh!

kyazdani42 commented Apr 28, 2022

Uh oh!

sarmong commented Apr 28, 2022

Uh oh!

kyazdani42 commented Apr 28, 2022

Uh oh!

alex-courtis left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyazdani42 left a comment

Uh oh!

Uh oh!

kyazdani42 left a comment

Uh oh!

alex-courtis May 9, 2022

Uh oh!

Uh oh!

alex-courtis May 9, 2022

Uh oh!

Uh oh!

Uh oh!

refactor: use lua api for user commands and autocommands #1206

refactor: use lua api for user commands and autocommands #1206

Uh oh!

Conversation

sarmong commented Apr 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alex-courtis left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alex-courtis left a comment

Choose a reason for hiding this comment

Uh oh!

alex-courtis commented Apr 28, 2022

Uh oh!

kyazdani42 commented Apr 28, 2022

Uh oh!

sarmong commented Apr 28, 2022

Uh oh!

kyazdani42 commented Apr 28, 2022

Uh oh!

alex-courtis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyazdani42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kyazdani42 left a comment

Choose a reason for hiding this comment

Uh oh!

alex-courtis May 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alex-courtis May 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sarmong commented Apr 27, 2022 •

edited

Loading

alex-courtis left a comment •

edited

Loading