Skip to content

refactor: use lua api for user commands and autocommands #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 14, 2022

Conversation

sarmong
Copy link
Collaborator

@sarmong sarmong commented Apr 27, 2022

I am still a bit new to autocommands, so please double-check that everything works

@sarmong sarmong marked this pull request as draft April 27, 2022 15:56
@sarmong sarmong marked this pull request as ready for review April 27, 2022 17:50
@sarmong sarmong changed the title refactor: use lua for preview autocommands refactor: use lua api for user commands and autocommands Apr 27, 2022
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the minimum version of neovim to 0.7

lua API for :au and :map was not reliable in 0.6

Edit: I see that you have already done this!

alex-courtis
alex-courtis previously approved these changes Apr 28, 2022
@alex-courtis alex-courtis dismissed their stale review April 28, 2022 00:58

incorrect

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update, thank you

@alex-courtis
Copy link
Member

We should do a neovim version check when nvim-tree starts.

< 0.7 will result in a warning and nvim-tree does not start.

@kyazdani42 ?

@kyazdani42
Copy link
Member

I'd prefer leaving a month to let people update before forcing this on everybody :) Some package managers might not have updated their neovim distribution yet.

@sarmong
Copy link
Collaborator Author

sarmong commented Apr 28, 2022

I'd prefer leaving a month to let people update before forcing this on everybody :) Some package managers might not have updated their neovim distribution yet.

Treesitter updated a couple days after the 0.7 release. And it is very likely that 90% of nvim-tree users use treesitter as well. So they either already updated everything, or know how hold updates if they don't want to

@kyazdani42
Copy link
Member

i guess so. Then, i'll test this properly this weekend and merge it if it's all okay :)

@alex-courtis alex-courtis self-requested a review April 30, 2022 00:12
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested most changes with 0.7.

Confirmed that it fails with 0.6.

We must add the startup version check before merging this.

Copy link
Member

@kyazdani42 kyazdani42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost good :) Could you rebase and manage the autocmd for coc diagnostic updates that has been just added ?
Also could you replace all the vim.api to api ? It's declared on top of the file :)

@sarmong sarmong requested review from kyazdani42 and alex-courtis and removed request for alex-courtis May 8, 2022 10:27
Copy link
Member

@kyazdani42 kyazdani42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @alex-courtis can you make a last review ? Then we'll merge.
I think i'll add a new issue for breaking change.

@@ -476,6 +502,11 @@ local function validate_options(conf)
end

function M.setup(conf)
if vim.fn.has "nvim-0.7" == 0 then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.6.1 exits early
0.7.0 works normally

@@ -504,6 +504,7 @@ end
function M.setup(conf)
if vim.fn.has "nvim-0.7" == 0 then
utils.warn "nvim-tree.lua requires Neovim 0.7 or higher"
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.

@sarmong sarmong requested a review from alex-courtis May 13, 2022 18:36
@kyazdani42 kyazdani42 merged commit 4601444 into nvim-tree:master May 14, 2022
mosheavni pushed a commit to mosheavni/nvim-tree.lua that referenced this pull request May 22, 2022
# This is the 1st commit message:

refactor: use lua api for user commands and autocommands (nvim-tree#1206)

BREAKING: plugin now requires nvim-0.7
# This is the commit message nvim-tree#2:

# This is a combination of 14 commits.tree a88ac1b
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

# This is a combination of 13 commits.
# This is the 1st commit message:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#2:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)


# This is the commit message nvim-tree#3:

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

# This is the commit message nvim-tree#4:

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

# This is the commit message nvim-tree#5:

fix(renderer): empty space at end of line

fixes nvim-tree#1253

# This is the commit message nvim-tree#6:

add fish performance tip to README.md
# This is the commit message nvim-tree#7:

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)


# This is the commit message nvim-tree#8:

feat: reload explorer on buf enter (nvim-tree#1265)


# This is the commit message nvim-tree#9:

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

# This is the commit message nvim-tree#10:

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

# This is the commit message nvim-tree#11:

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

# This is the commit message nvim-tree#12:

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)


# This is the commit message nvim-tree#13:

Ignore case when removing default mappings

# This is the commit message nvim-tree#14:

issue#362: File Management popup menu UI. First Iteration.

# This is the commit message nvim-tree#3:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

# This is the commit message nvim-tree#4:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

# This is the commit message nvim-tree#5:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

# This is the commit message nvim-tree#6:

# This is a combination of 21 commits.
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

# This is a combination of 13 commits.
# This is the 1st commit message:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#2:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)


# This is the commit message nvim-tree#3:

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

# This is the commit message nvim-tree#4:

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

# This is the commit message nvim-tree#5:

fix(renderer): empty space at end of line

fixes nvim-tree#1253

# This is the commit message nvim-tree#6:

add fish performance tip to README.md
# This is the commit message nvim-tree#7:

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)


# This is the commit message nvim-tree#8:

feat: reload explorer on buf enter (nvim-tree#1265)


# This is the commit message nvim-tree#9:

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

# This is the commit message nvim-tree#10:

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

# This is the commit message nvim-tree#11:

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

# This is the commit message nvim-tree#12:

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)


# This is the commit message nvim-tree#13:

Ignore case when removing default mappings

# This is the commit message nvim-tree#14:

issue#362: File Management popup menu UI. First Iteration.

# This is the commit message nvim-tree#15:

Workin on menu refactoring

# This is the commit message nvim-tree#17:

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

# This is the commit message nvim-tree#18:

Update README.md

# This is the commit message nvim-tree#19:

updated popup-menu/init.lua

# This is the commit message nvim-tree#20:

Update init.lua
# This is the commit message nvim-tree#21:

Update README.md
# This is the commit message nvim-tree#7:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done

# This is the commit message nvim-tree#8:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#9:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)
mosheavni pushed a commit to mosheavni/nvim-tree.lua that referenced this pull request May 22, 2022
# This is the 1st commit message:

refactor: use lua api for user commands and autocommands (nvim-tree#1206)

BREAKING: plugin now requires nvim-0.7
# This is the commit message nvim-tree#2:

# This is a combination of 14 commits.tree a88ac1b
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

# This is a combination of 13 commits.
# This is the 1st commit message:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#2:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)


# This is the commit message nvim-tree#3:

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

# This is the commit message nvim-tree#4:

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

# This is the commit message nvim-tree#5:

fix(renderer): empty space at end of line

fixes nvim-tree#1253

# This is the commit message nvim-tree#6:

add fish performance tip to README.md
# This is the commit message nvim-tree#7:

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)


# This is the commit message nvim-tree#8:

feat: reload explorer on buf enter (nvim-tree#1265)


# This is the commit message nvim-tree#9:

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

# This is the commit message nvim-tree#10:

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

# This is the commit message nvim-tree#11:

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

# This is the commit message nvim-tree#12:

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)


# This is the commit message nvim-tree#13:

Ignore case when removing default mappings

# This is the commit message nvim-tree#14:

issue#362: File Management popup menu UI. First Iteration.

# This is the commit message nvim-tree#3:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

# This is the commit message nvim-tree#4:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

# This is the commit message nvim-tree#5:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

# This is the commit message nvim-tree#6:

# This is a combination of 21 commits.
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

# This is a combination of 13 commits.
# This is the 1st commit message:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#2:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)


# This is the commit message nvim-tree#3:

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

# This is the commit message nvim-tree#4:

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

# This is the commit message nvim-tree#5:

fix(renderer): empty space at end of line

fixes nvim-tree#1253

# This is the commit message nvim-tree#6:

add fish performance tip to README.md
# This is the commit message nvim-tree#7:

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)


# This is the commit message nvim-tree#8:

feat: reload explorer on buf enter (nvim-tree#1265)


# This is the commit message nvim-tree#9:

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

# This is the commit message nvim-tree#10:

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

# This is the commit message nvim-tree#11:

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

# This is the commit message nvim-tree#12:

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)


# This is the commit message nvim-tree#13:

Ignore case when removing default mappings

# This is the commit message nvim-tree#14:

issue#362: File Management popup menu UI. First Iteration.

# This is the commit message nvim-tree#15:

Workin on menu refactoring

# This is the commit message nvim-tree#17:

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

# This is the commit message nvim-tree#18:

Update README.md

# This is the commit message nvim-tree#19:

updated popup-menu/init.lua

# This is the commit message nvim-tree#20:

Update init.lua
# This is the commit message nvim-tree#21:

Update README.md
# This is the commit message nvim-tree#7:

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done

# This is the commit message nvim-tree#8:

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)


# This is the commit message nvim-tree#9:

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)


# This is the commit message nvim-tree#10:

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

# This is the commit message nvim-tree#11:

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253
mosheavni pushed a commit to mosheavni/nvim-tree.lua that referenced this pull request May 22, 2022
)

BREAKING: plugin now requires nvim-0.7

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done
parent 4601444
author Kiyan <yazdani.kiyan@protonmail.com> 1652514867 +0200
committer Moshe Avni <mavni@netapp.com> 1653224067 +0300

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

Ignore case when removing default mappings

issue#362: File Management popup menu UI. First Iteration.

Workin on menu refactoring

Working MVP of NvimTree menu. Added Readme.md with explanation of the current state of feature and DEFAULT_OPTIONS to test.

Update README.md

updated popup-menu/init.lua

Update init.lua

Update README.md

Done

feat(renderer): add ability to set git icons in signcolumn (nvim-tree#1242)

feat: extension sorter (nvim-tree#1181) (nvim-tree#1264)

Revert "nvim-tree#1253 only pad git icons when they are present (nvim-tree#1259)"

This reverts commit 90d7b8e.
fixes nvim-tree#1267

fix(renderer): padding when git icons are after the name

fixes nvim-tree#1253

fix(renderer): empty space at end of line

fixes nvim-tree#1253

add fish performance tip to README.md

feat(live-filter): add ability to live filter out nodes in the tree (nvim-tree#1056)

feat: reload explorer on buf enter (nvim-tree#1265)

chore(config): auto resize the tree by default when opening a file.

config.open_file.auto_resize is now true by default.
Breaking change for default configurations.
See nvim-tree#1275 (comment)

chore: remove custom set local implementation

Seems vim.opt_local has been fixed.
see neovim/neovim#14670

refactor: simplify opening file in new tab

fixes nvim-tree#1271. Also fixes opening a file in new tab when close_on_open was
true.

This introduces breaking change since we don't do any extra behavior
and let the buffer be opened by the tree.
The previous behavior was a bit old and i believe this should've been
fixed by now.
Reference this commit if unexpected behavior appears while opening files
in new tabs from nvim-tree.

feat: optional path argument for NvimTreeToggle and NvimTreeFindFileToggle (nvim-tree#1276)

remove
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants