Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add instruction about how to use nightly build #1507

Closed
wants to merge 1 commit into from

Conversation

PeterDaveHello
Copy link
Collaborator

@PeterDaveHello PeterDaveHello commented Apr 16, 2017

I can remove [ci skip] in commit message once it looks good enough :)

cc #1053

This was referenced Apr 16, 2017
@ljharb
Copy link
Member

ljharb commented Apr 16, 2017

No; nvm does not support nightly builds currently; as such, there should be no official instructions for using them.

@ljharb ljharb closed this Apr 16, 2017
@PeterDaveHello
Copy link
Collaborator Author

Doesn't #1508 just support it?

@ljharb
Copy link
Member

ljharb commented Apr 16, 2017

Not properly.

Either way, documentation should go in the same commit/PR as the feature itself.

As documented, people who follow these instructions (I'm aware they're being provided elsewhere) will break when proper nightly support lands. It is a very bad idea for anybody to use nvm to install nightlies prior to it officially supporting them.

@PeterDaveHello
Copy link
Collaborator Author

So that's why I want to make it documentation not sure elsewhere, can we keep discussion on #1508?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants