-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] nvm ls
for nightly builds
#1508
Conversation
4aa47a3
to
1834034
Compare
1834034
to
c8af6ab
Compare
Thanks, but this is not how I have already begun to implement this feature. |
@ljharb so how should it be? Can we just make it work before the new implementation? |
No, if you look at the road map, RC support needs to come before nightly support (since RCs are way way more important for people to use than nightlies), and I've already mostly implemented that. The only people who should be installing nightlies are node core developers, and they don't need nvm to be easy to use for that use case. It's not urgent. |
So you are working on both RC and nightly support? |
Yes, they will follow a similar implementation pattern. |
okay ... |
@ljharb is it possible to reveal the progress as transparency so that we can prevent to work on the same thing? IMO RC support vs nightly needs only few tweaks. |
There's a number of bugs in the issues list, some filed by yourself, that should all be worked on before trying to implement a new feature - no matter how small you believe the changes will be. |
I think it's ... not the same thing we are talking about. |
I'm suggesting that you not work on new features until we're out of bugs, if you want to be able to work on things, without asking first, without fear of overlapping with what I'm working on. |
I can understand what do you mean but this didn't explain the possibility if we can have transparency of the new features, no matter what the decision is, it's fine to respect it. |
https://github.com/creationix/nvm/blob/master/ROADMAP.md has been there since September. |
Oh yes, I saw the issues, I mean the code level progress in branches or PRs, is that possible? The reality to me about the other issues is that I'm still working on them, I didn't drop them, and to be honest, I also really hope you can help solve the tests running locally issue first because testing on Travis CI is not that efficient and sometimes wasting resources, even makes it hard to debug sometimes, and that's the part very hard for me, which also slows down my progress on the other PRs, IMO you may be the best one to work on the testing issue. |
Without this patch, how the
nvm ls
looks like (the display format is not correct):With this patch, now we have correct
nvm ls
, and the nightly builds with have their own color:cc #1053 #1507