Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nodejs release candidates #712

Closed
wants to merge 1 commit into from

Conversation

misterdjules
Copy link

See nodejs/node-v0.x-archive#14412 for more details on a
proposal to include release candidates in Node.js' release process.

The goal of this PR is first to get some initial feedback on:

  1. Having release candidates done during Node.js' release process.
  2. The actual change, and the nomenclature that has currently been chosen for these release candidates releases (the (-rc\d+)? addition to the ls-remote regexp).

This change has been tested with a "fake" release candidate of Node.js available here: https://nodejs.org/dist/v0.12.3-rc1/.

See nodejs/node-v0.x-archive#14412 for more details on a
proposal to include release candidates in Node.js' release process.
@ljharb
Copy link
Member

ljharb commented Apr 3, 2015

Does this work with all of nvm use, nvm install, a .nvmrc file, nvm alias, nvm uninstall, nvm ls, nvm ls-remote?

It's really unfortunate that this decision was made without even checking with version managers - the existence of that release candidate is breaking nvm (see #711).

@misterdjules
Copy link
Author

This change has been tested only with nvm install v0.12.3-rc1. The goal of this PR is to get initial feedback on:

  1. The concept of having release candidates.
  2. The steps that need to be taken to ensure that this doesn't break users of nvm or other versions managers.

I will do additional testing with all the commands you mentioned above, thank you! This time though I will not use nodejs.org to host the release candidates when testing.

Last but not least, this decision to have release candidates has not been made yet. The purpose of this PR is to check with version managers first, like the original comment says:

The goal of this PR is first to get some initial feedback

The reason why the v0.12.3-rc1 was still available on nodejs.org is a mistake on my side, it should not have stayed there and was used for testing purposes. It's been removed, I apologize for the confusion.

@ljharb ljharb added installing node Issues with installing node/io.js versions. feature requests I want a new feature in nvm! labels Apr 3, 2015
@ljharb ljharb self-assigned this Apr 3, 2015
@ljharb
Copy link
Member

ljharb commented Jun 7, 2015

Per nodejs/node#1854 (comment), I'll be adding io.js rc support, and future node versions will follow the same format.

@ljharb
Copy link
Member

ljharb commented Jul 4, 2015

Closing this in favor of #779. Thanks for the contribution!

@ljharb ljharb closed this Jul 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature requests I want a new feature in nvm! installing node Issues with installing node/io.js versions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants