Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stdoutEncoding option #26

Merged
merged 3 commits into from
Nov 16, 2022
Merged

add stdoutEncoding option #26

merged 3 commits into from
Nov 16, 2022

Conversation

danunafig
Copy link
Contributor

Added control over stdout encoding for spawned process

@nvuillam
Copy link
Owner

@danunafig why commenting your testmethod ? ^^

@danunafig
Copy link
Contributor Author

@danunafig why commenting your testmethod ? ^^

fixed

@nvuillam
Copy link
Owner

a typo remaining ^^

image

@codecov-commenter
Copy link

Codecov Report

Base: 86.54% // Head: 86.66% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (54000b6) compared to base (ed9d717).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   86.54%   86.66%   +0.11%     
==========================================
  Files           3        3              
  Lines         223      225       +2     
==========================================
+ Hits          193      195       +2     
  Misses         30       30              
Impacted Files Coverage Δ
lib/java-caller.js 85.43% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nvuillam nvuillam merged commit 8bde472 into nvuillam:master Nov 16, 2022
@nvuillam nvuillam mentioned this pull request Nov 16, 2022
@nvuillam
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants